Author: ovyalov
Date: Thu Jul 21 12:03:25 2016
New Revision: 276303
URL: http://llvm.org/viewvc/llvm-project?rev=276303=rev
Log:
Add check for non-null log instance in PlatformAndroid.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Modified:
Author: ovyalov
Date: Tue Jul 12 13:14:27 2016
New Revision: 275198
URL: http://llvm.org/viewvc/llvm-project?rev=275198=rev
Log:
Add logging to Linux Host::GetProcessAndStatInfo.
Modified:
lldb/trunk/source/Host/linux/Host.cpp
Modified: lldb/trunk/source/Host/linux/Host.cpp
URL:
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Users:
ovyalov (Author)
Author: ovyalov
Date: Fri Jul 8 12:45:37 2016
New Revision: 274895
URL: http://llvm.org/viewvc/llvm-project?rev=274895=rev
Log:
Use shell cat command as a workaround if ADB stat cannot lookup a file.
http://reviews.llvm.org/D22081
Modified:
ovyalov updated this revision to Diff 63255.
ovyalov added a comment.
Reran with proper clang-format.
http://reviews.llvm.org/D22081
Files:
source/Plugins/Platform/Android/AdbClient.cpp
source/Plugins/Platform/Android/AdbClient.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
ovyalov added a comment.
In http://reviews.llvm.org/D22081#477746, @labath wrote:
> Thanks for adding the additional checks. Looks good apart from the
> clang-format changes. This looks like the llvm style. I am not sure how
> you've run this but it does not seem to have picked up LLDB's
ovyalov added a comment.
In http://reviews.llvm.org/D22081#476766, @labath wrote:
> You raised good points here, Luke.
>
> I've thought about the quoting issue, but as you have already noticed there
> is no way to pass arguments containing quotes to adb correctly. Thinking
> about it more,
ovyalov updated this revision to Diff 63173.
ovyalov added a comment.
Addressed review comments:
- Check whether shell command output starts with /system/bin/sh: in order to
find out whether command failed
- Fail-fast download if filename contains single-quotes
- clang-format
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
adbd may fail to access a file due security constraints - in such case
sync:stat command returns file's mode as 0. If it's the
ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:71
@@ +70,3 @@
+{
+if (const char *android_serial = std::getenv("ANDROID_SERIAL"))
+adb.SetDeviceID(android_serial);
Could you check
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Author: ovyalov
Date: Wed Jul 6 12:02:42 2016
New Revision: 274638
URL: http://llvm.org/viewvc/llvm-project?rev=274638=rev
Log:
Fix ADB client disconnect issues.
http://reviews.llvm.org/D22029
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: ovyalov
Date: Tue Jul 5 21:20:39 2016
New Revision: 274594
URL: http://llvm.org/viewvc/llvm-project?rev=274594=rev
Log:
Fix Linux build.
Modified:
lldb/trunk/source/Core/UserSettingsController.cpp
Modified: lldb/trunk/source/Core/UserSettingsController.cpp
URL:
Author: ovyalov
Date: Thu Jun 30 13:10:27 2016
New Revision: 274256
URL: http://llvm.org/viewvc/llvm-project?rev=274256=rev
Log:
Improve ADB utilization within Android platform.
http://reviews.llvm.org/D21770
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
ovyalov added a comment.
If you okay with that I'd like to submit this CL as-is and come up with unit
test with a separate change list.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
- Extract sync commands like push/pull file and stat into SyncService so ADB
connection that's switched in sync mode can be
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D21680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r270590
http://reviews.llvm.org/D20548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue May 24 13:09:05 2016
New Revision: 270590
URL: http://llvm.org/viewvc/llvm-project?rev=270590=rev
Log:
Replace file system forbidden symbols in the hostname which passed to the
ModuleCache.
http://reviews.llvm.org/D20548
Modified:
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437567, @labath wrote:
> According to
> https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255=-2147217396,
> characters with codes 1..31 (basically `< ' '`), are illegal as well. We
> might as well
ovyalov updated this revision to Diff 58180.
ovyalov added a comment.
Added asterisk symbol
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
---
ovyalov created this revision.
ovyalov added reviewers: labath, clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
ModuleCache hostname may contain symbols that are not allowed in filenames -
for example, in Android device_id is used as a
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
Looks like this CL broke CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634,
could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D19124
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 100; // 1 second
+const uint32_t kReadTimeout = 400; // 4 seconds
const char * kOKAY = "OKAY";
It might be
Author: ovyalov
Date: Sat Apr 16 11:29:17 2016
New Revision: 266530
URL: http://llvm.org/viewvc/llvm-project?rev=266530=rev
Log:
Fix cmake build after r266524.
Modified:
lldb/trunk/source/Core/RegisterValue.cpp
Modified: lldb/trunk/source/Core/RegisterValue.cpp
URL:
Author: ovyalov
Date: Thu Apr 14 19:56:11 2016
New Revision: 266401
URL: http://llvm.org/viewvc/llvm-project?rev=266401=rev
Log:
Rename out->std_out in AppleObjCRuntimeV2.cpp.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
ovyalov added a comment.
In http://reviews.llvm.org/D19092#401450, @jingham wrote:
> Why is this necessary? stdout is a local variable defined in this scope.
> Why would the android g++ have problems with this?
>
> Anyway, if you have to avoid using stdout as a name, maybe name it std_out as
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL266274
http://reviews.llvm.org/D19092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Wed Apr 13 21:02:12 2016
New Revision: 266274
URL: http://llvm.org/viewvc/llvm-project?rev=266274=rev
Log:
Fix Android build after r266267
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
ovyalov created this revision.
ovyalov added a reviewer: granata.enrico.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix Android build after r266267
http://reviews.llvm.org/D19092
Files:
Author: ovyalov
Date: Tue Apr 12 23:21:05 2016
New Revision: 266164
URL: http://llvm.org/viewvc/llvm-project?rev=266164=rev
Log:
Attempt to fix TestCPPBreakpointLocations on Linux/Android.
Modified:
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
You may remove iostream
ovyalov added a comment.
In http://reviews.llvm.org/D18886#397637, @amccarth wrote:
> FYI: According to git bisect, this patch seems to have introduced a new test
> failure on Windows.
Thanks for the report - will fix today.
http://reviews.llvm.org/D18886
Author: ovyalov
Date: Fri Apr 8 22:08:02 2016
New Revision: 265869
URL: http://llvm.org/viewvc/llvm-project?rev=265869=rev
Log:
Fix TestBreakpointSetRestart failure on Android.
Modified:
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL265843
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: ovyalov
Date: Fri Apr 8 15:44:28 2016
New Revision: 265843
URL: http://llvm.org/viewvc/llvm-project?rev=265843=rev
Log:
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
http://reviews.llvm.org/D18886
Added:
ovyalov added a comment.
In http://reviews.llvm.org/D18886#395216, @labath wrote:
> Does this fix an existing test or is a new issue? If it's new (it sounds like
> it is, as I don't see any test failures), could you also add a test for this.
> It shouldn't be too difficult to write one...
ovyalov updated this revision to Diff 53054.
ovyalov added a comment.
Added new TestBreakpointSetRestart test to cover the addressed issue.
http://reviews.llvm.org/D18886
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/Makefile
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received -
otherwise it leads to stopped inferior when setting breakpoint (when
m_interrupt_sent == true and signal is
ovyalov accepted this revision.
ovyalov added a comment.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D18858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext ,
const DWARFDIE ,
+ lldb_private::Log
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D17604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:250
@@ +249,3 @@
+log->Printf("NativeThreadLinux::%s Unable to get cpu affinity for
thread %" PRIx64 ": %s", __FUNCTION__,
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D17131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22
@@ -20,1 +21,3 @@
+# Backtracing failed due to lack of prolog/epilog informations in assert
function of libc.so.6
+
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL259714
http://reviews.llvm.org/D16861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: ovyalov
Date: Wed Feb 3 16:02:43 2016
New Revision: 259714
URL: http://llvm.org/viewvc/llvm-project?rev=259714=rev
Log:
Pass socket scheme as part of debug server listen URL.
http://reviews.llvm.org/D16861
Modified:
ovyalov created this revision.
ovyalov added reviewers: sivachandra, tberghammer.
ovyalov added a subscriber: lldb-commits.
Pass socket scheme as part of debug server listen URL in order to fix custom
protocols like unix-abstract.
http://reviews.llvm.org/D16861
Files:
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue Jan 19 11:54:47 2016
New Revision: 258150
URL: http://llvm.org/viewvc/llvm-project?rev=258150=rev
Log:
Implementing the method Target::TargetEventData::Dump (Stream *s) so that its
clients can easily dump it out for informational messages.
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL258150
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
If vdso bug pertains to ELF format then it looks reasonable to keep the fix
within ObjectFileELF.
I experimented a while ago with making ObjectFileELF to read from arbitrary
offsets - please see http://reviews.llvm.org/D16151 as reflection of this idea
(patch is pretty
ovyalov added a comment.
vdso issue is related to ELF format and I'm wondering whether we can keep the
fix contained in ObjectFileELF - for example, if a section that we're trying to
read is beyond the boundaries of memory buffer we can read its content from
inferior's memory using
ovyalov accepted this revision.
Comment at:
packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassembleRawData.py:29
@@ +28,3 @@
+elif re.match("mips",arch):
+ target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "mips")
+
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:973
@@ +972,3 @@
+{
+// PTRACE_PEEKUSER don't work in the aarch64 liux kernel used on android
devices (always return
+
Author: ovyalov
Date: Fri Dec 11 20:13:17 2015
New Revision: 255419
URL: http://llvm.org/viewvc/llvm-project?rev=255419=rev
Log:
Remove unused mips typedefs.
Modified:
lldb/trunk/source/Plugins/Process/Linux/Procfs.h
Modified: lldb/trunk/source/Plugins/Process/Linux/Procfs.h
URL:
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
Just out of curiosity
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL254638
http://reviews.llvm.org/D15172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r250474
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Debug sections for JIT-ed code are stored in-memory and loaded as part of
module's image once __jit_debug_register_code is called -
if we cannot load a section by its base
Author: ovyalov
Date: Mon Nov 23 13:32:24 2015
New Revision: 253906
URL: http://llvm.org/viewvc/llvm-project?rev=253906=rev
Log:
Prevent ProcessGDBRemote from launching local debug server in case of remote
debug server connection failure.
http://reviews.llvm.org/D14895
Modified:
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
Users:
ovyalov (Author)
http://reviews.llvm.org/rL253906
http://reviews.llvm.org/D14895
ovyalov updated this revision to Diff 40948.
ovyalov added a comment.
Addressed review comments - renamed the method to EstablishConnectionIfNeeded.
http://reviews.llvm.org/D14895
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath.
ovyalov added a subscriber: lldb-commits.
If remote platform is used and we're losing remote debug server connection in
between Process::ConnectRemote and Process::Attach (in context of
PlatformRemoteGDBServer::Attach)
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D14816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: packages/Python/lldbsuite/test/lldbtest.py:464
@@ -463,3 +463,3 @@
parsed_url = urlparse.urlparse(lldb.platform_url)
-if parsed_url.scheme
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14634
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Files:
ovyalov created this revision.
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
Pass symbol file platform's file spec to ModuleCache::Put - i.e., to make sym
link path like this:
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL251871
http://reviews.llvm.org/D14264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: ovyalov
Date: Mon Nov 2 19:37:01 2015
New Revision: 251879
URL: http://llvm.org/viewvc/llvm-project?rev=251879=rev
Log:
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Modified:
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
ovyalov added a comment.
In http://reviews.llvm.org/D14118#277675, @ravitheja wrote:
> Hi,
>
> This link for the traces needs a password, could u maybe provide me the
> login details or upload these somewhere else ? Also could u provide me the
> value of the AuxVectors during this test ?
ovyalov added a comment.
Hi,
looks like TestHelloWorld and TestInferiorAssert began to fail after this
change -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7880
Could you mark these tests as XFAILs for now?
http://reviews.llvm.org/D14118
Author: ovyalov
Date: Wed Oct 28 17:21:02 2015
New Revision: 251563
URL: http://llvm.org/viewvc/llvm-project?rev=251563=rev
Log:
Remove unused SUN_LEN macro for Android.
Modified:
lldb/trunk/source/Host/posix/DomainSocket.cpp
Modified: lldb/trunk/source/Host/posix/DomainSocket.cpp
URL:
Author: ovyalov
Date: Tue Oct 27 12:32:01 2015
New Revision: 251417
URL: http://llvm.org/viewvc/llvm-project?rev=251417=rev
Log:
Add Socket::Create factory method which uses socket protocol to find an
appropriate implementation class.
http://reviews.llvm.org/D14085
Modified:
ovyalov accepted this revision.
ovyalov added a comment.
Looks good - minor comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:513
@@ +512,3 @@
+{
+FileSpec file_spec;
+file_spec.SetFile("[vdso]", false);
ovyalov updated this revision to Diff 38588.
ovyalov added a comment.
Addressed review comments - please take another look.
http://reviews.llvm.org/D14126
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Make lldb-gdbserver to take explicit socket scheme as command line argument -
so lldb gdb-server uses the same socket type as platform does.
http://reviews.llvm.org/D14126
Files:
ovyalov added a comment.
In http://reviews.llvm.org/D14085#275442, @zturner wrote:
> I'm not sure I agree with this change. The interface to programming with
> socket is by definition a property of the Host operating system. It seems to
> me like Host was already the correct place for this
ovyalov retitled this revision from "Make Socket to support plugin interface"
to "Add Socket::Create factory method which uses socket scheme (tcp, unix,..)
to find an appropriate implementation class.".
ovyalov updated the summary for this revision.
ovyalov updated this revision to Diff 38484.
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
We can connect to a device using various protocols (tcp, unix domain, abstract).
Instead of adding new URL schemes (e.g.,
ovyalov added a comment.
In http://reviews.llvm.org/D13970#273217, @clayborg wrote:
> Looks good. At some point we should add these to the PluginMananger and have
> new instances found by having them register URL prefixes which match up with
> CreateInstance methods that are given the URL.
Author: ovyalov
Date: Thu Oct 22 12:50:33 2015
New Revision: 251034
URL: http://llvm.org/viewvc/llvm-project?rev=251034=rev
Log:
Add support for abstract domain sockets.
http://reviews.llvm.org/D13970
Added:
lldb/trunk/include/lldb/Host/linux/AbstractSocket.h
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/lldb.xcodeproj/project.pbxproj
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
ovyalov added a comment.
In http://reviews.llvm.org/D13881#270878, @labath wrote:
> I *think* it looks good, but I find it quite hard to review a change of this
> size.
> A wise man once said "if your commit description contains bullet points, you
> are doing too much". I think it would be
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This CL provides logic for running lldb-server on domain sockets and required
gdb-remote infrastructure
ovyalov added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
labath wrote:
> If we're going to use unique names, then this won't be necessary (and I would
> much
Author: ovyalov
Date: Thu Oct 15 18:54:09 2015
New Revision: 250474
URL: http://llvm.org/viewvc/llvm-project?rev=250474=rev
Log:
Split Socket class into Tcp/Udp/DomainSocket subclasses.
http://reviews.llvm.org/D13754
Added:
lldb/trunk/include/lldb/Host/common/TCPSocket.h
ovyalov updated this revision to Diff 37525.
ovyalov marked 3 inline comments as done.
ovyalov added a comment.
Addressed review suggestions.
Please take another look.
http://reviews.llvm.org/D13754
Files:
include/lldb/Host/Socket.h
include/lldb/Host/common/TCPSocket.h
ovyalov added inline comments.
Comment at: source/Host/common/Socket.cpp:356
@@ -740,3 +355,3 @@
-uint16_t Socket::GetLocalPortNumber(const NativeSocket& socket)
+size_t Socket::Send(const void *buf, const size_t num_bytes)
{
Good point - done.
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r234610
http://reviews.llvm.org/D8977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: clayborg, zturner, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There are a few reasons for this change:
- Support generic logic flow for different socket types - a preparation
Author: ovyalov
Date: Fri Oct 2 17:37:55 2015
New Revision: 249203
URL: http://llvm.org/viewvc/llvm-project?rev=249203=rev
Log:
Fix TestCompDirSymLink.py - remove existing symlink leftovers if previous test
run
was terminated (e.g., due timeout).
Modified:
Author: ovyalov
Date: Thu Oct 1 14:08:00 2015
New Revision: 249055
URL: http://llvm.org/viewvc/llvm-project?rev=249055=rev
Log:
Fix Android build after r249047.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Modified:
1 - 100 of 133 matches
Mail list logo
