paulherman created this revision.
paulherman added reviewers: sivachandra, chaoren, tberghammer, clayborg.
paulherman added a subscriber: lldb-commits.
http://reviews.llvm.org/D12942
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Index:
paulherman updated this revision to Diff 35026.
paulherman added a comment.
Fix caching for clang::Decl in DWARFASTParserClang
Changed from std::set to switch. Rebased the patch.
http://reviews.llvm.org/D12942
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Index:
paulherman updated this revision to Diff 34911.
paulherman added a comment.
Add using directives to the clang::DeclContext and fix decls for variables
inside namespaces
Rebased the patch.
http://reviews.llvm.org/D12897
Files:
include/lldb/Symbol/SymbolFile.h
paulherman added a comment.
The need for ParseDeclsInContext is to get a list of namespaces that are
contained within a using-directive. This does not actually parse anything but
DW_TAG_imported_namespace and DW_TAG_imported_decl. The actual contents of the
namespace are parsed only when the
paulherman added a comment.
The test was supposed to be marked as an XFAIL. I'm currently writing a fix for
this that reports ambiguity in a context and deals with imported decls.
http://reviews.llvm.org/D12658
___
lldb-commits mailing list
paulherman updated this revision to Diff 34850.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
Rebased the patch.
http://reviews.llvm.org/D12658
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
Author: paulherman
Date: Tue Sep 15 18:44:17 2015
New Revision: 247746
URL: http://llvm.org/viewvc/llvm-project?rev=247746=rev
Log:
Search variables based on clang::DeclContext and clang::Decl tree
Summary: SymbolFileDWARF now creates VarDecl and BlockDecl and adds them to the
Decl tree. Then,
Author: paulherman
Date: Tue Sep 15 19:29:10 2015
New Revision: 247760
URL: http://llvm.org/viewvc/llvm-project?rev=247760=rev
Log:
Fix double include in CompilerDeclContext.h
Modified:
lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h
Modified:
paulherman updated this revision to Diff 34808.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
http://reviews.llvm.org/D12658
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
paulherman updated this revision to Diff 34823.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
This adds handling of imported declarations, but there is no call to actually
process them as I am not sure where to do this. I believe that the right
paulherman added a comment.
If I move the call to DeclLinkDeclToObject inside any of the GetDeclXXX
methods, then there is no way to access the VariableSP needed for the call and
it is probably harder to reconstruct the parameters needed for ParseVariableDIE
starting from just the DIE itself.
paulherman added a comment.
I thought about the problem a bit more and I believe that having the call to
DeclLinkDeclToObject inside ParseVariableDIE makes sense since this gets called
only when the variable will actually be used in a search together with its
context. Also, since
paulherman added a comment.
Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call
and I only remove that? This is the only place where GetDecl is called, so it
would be equivalent from a computational point of view.
http://reviews.llvm.org/D12658
paulherman added a comment.
I just ran a grep through the source. It seems that everywhere it is created as
a shared_ptr. In a previous attempt I tried storing it in the TypeSystem map
from decl to object as Variable* instead of VariableSP and it seemed like at
some point between launching a
paulherman updated this revision to Diff 34768.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
Moved the DeclLinkToObject inside Variable::GetDecl.
http://reviews.llvm.org/D12658
Files:
include/lldb/Symbol/ClangASTContext.h
paulherman added a comment.
In http://reviews.llvm.org/D12658#245466, @clayborg wrote:
> In http://reviews.llvm.org/D12658#244710, @paulherman wrote:
>
> > [WIP] Search variables based on clang::DeclContext and clang::Decl tree
> >
> > This revision fixes some of the comments. There are some
paulherman added a comment.
I think the only concern left might be the call to DeclLinkToObject in
ParseVariableDIE. It doesn't have anything to do with clang but I feel like
there should be a way to do this lazily.
Otherwise, I believe that the comments have been addressed.
Thank you!
paulherman updated this revision to Diff 34616.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
I believe I fixed most of the comments. I removed the handling of using
declarations for now and made the test an expected failure because of this. I
paulherman added a comment.
I agree with most of your comments and will fix them.
One thing I noticed is that Block::GetDeclContext() does not do the right thing
(see inline comment).
About creating a CompilerDecl class, I agree with you. I used
CompilerDeclContext since it was just a void*
paulherman added a comment.
I believe that the approach of CompilerDeclContext::FindDecls could be better.
But then this kind of forces CompilerDeclContext to inherit CompilerDecl (a
function is both a DeclContext and a Decl) and I believe that creating a class
for each possible entity is an
paulherman added a comment.
Ping.
http://reviews.llvm.org/D12658
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
paulherman created this revision.
paulherman added a reviewer: sivachandra.
paulherman added a subscriber: lldb-commits.
http://reviews.llvm.org/D12165
Files:
test/lang/cpp/chained-calls/TestCppChainedCalls.py
test/lang/cpp/chained-calls/main.cpp
test/lang/cpp/nsimport/TestCppNsImport.py
paulherman updated this revision to Diff 32593.
paulherman added a comment.
Improve tests regarding imported namespaces and chained calls in C++
http://reviews.llvm.org/D12165
Files:
test/lang/cpp/chained-calls/TestCppChainedCalls.py
test/lang/cpp/chained-calls/main.cpp
Author: paulherman
Date: Wed Aug 19 17:44:48 2015
New Revision: 245515
URL: http://llvm.org/viewvc/llvm-project?rev=245515view=rev
Log:
Fix tests to work on remote targets.
Modified:
lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py
Author: paulherman
Date: Wed Aug 19 16:44:56 2015
New Revision: 245508
URL: http://llvm.org/viewvc/llvm-project?rev=245508view=rev
Log:
Fix evaluation of global operators in C++
Added:
lldb/trunk/test/lang/cpp/global_operators/
lldb/trunk/test/lang/cpp/global_operators/Makefile
Author: paulherman
Date: Tue Aug 18 17:43:37 2015
New Revision: 245380
URL: http://llvm.org/viewvc/llvm-project?rev=245380view=rev
Log:
Test chaned function calls and imported namespaces in C++
Added:
lldb/trunk/test/lang/cpp/chained-calls/
lldb/trunk/test/lang/cpp/chained-calls/Makefile
26 matches
Mail list logo
