[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc08d3b08f6d7: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions (authored by pfaffe). Changed prior to commit: https://reviews.llvm.org/D137247?vs=477099=477175#toc

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 477099. pfaffe marked 2 inline comments as done. pfaffe added a comment. Override new functions in DWOs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files:

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added a comment. I threaded dwarf_cu down to where it's really used and added the necessary check, so if it is nullptr, the fallback will be skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 475399. pfaffe added a comment. Stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files: lldb/include/lldb/Expression/DWARFExpression.h

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added inline comments. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:719 + Type:ET_EXEC + Machine: EM_386 +Sections: DavidSpickett wrote: > I know it's just a test but is there an `EM_WASM` you could use? > > Maybe

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 472863. pfaffe marked 4 inline comments as done. pfaffe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files:

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added a comment. Yes, you got the context right! Although technically speaking this change isn't limited to wasm, plugins can implement any vendor extension on top of this change. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:93 const DWARFExpression

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe created this revision. pfaffe added reviewers: labath, DavidSpickett. Herald added a project: All. pfaffe requested review of this revision. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. Parsing DWARF expressions currently does not support DW_OPs that are

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGd839f654586a: [wasm] Always treat DWARF expression addresses as load addresses (authored by pfaffe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471543. pfaffe added a comment. Add unittest for DW_OP_addrx as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files:

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471486. pfaffe added a comment. Bring back lost changes... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471485. pfaffe added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files: lldb/source/Expression/DWARFExpression.cpp Index:

[Lldb-commits] [PATCH] D135664: [wasm] Always treat DWARF expression addresses as load addresses

pfaffe updated this revision to Diff 471484. pfaffe added a comment. Herald added a subscriber: lldb-commits. Full context with arcanist Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 Files:

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

pfaffe added a comment. In D97786#2974879 , @dblaikie wrote: > Not fixable? Not sure I follow. In the case of cwd-relative (old behavior) > you can fix the behavior by changing where you invoke the debugger from, and > in the case of exe-relative you

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

pfaffe added a comment. In D97786#2973868 , @dblaikie wrote: > This doesn't solve all use cases/it's not a terribly general purpose > situation - using -fdebug-prefix-map/-fdebug-compilation-dir requires > knowledge of these limitations/how to use these

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

pfaffe added a comment. This change breaks all existing uses of relative comp_dirs that don't accidentally make all of them relative to the executable's directory already. It's easy to construct broken use cases: Consider compiling your program like `clang -g ./src/src.c -gsplit-dwarf -o

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

pfaffe added a comment. Thanks! Would you mind landing the change for me? I'm not a github comitter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93621/new/ https://reviews.llvm.org/D93621 ___

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

pfaffe updated this revision to Diff 313321. pfaffe added a comment. Add the new dwo sections to the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93621/new/ https://reviews.llvm.org/D93621 Files:

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

pfaffe created this revision. Herald added subscribers: sunfish, sbc100. pfaffe requested review of this revision. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. Mirror ELF section parsing to support DWARF section names for debug fission. Repository: rG LLVM