Ilod created this revision.
Ilod added reviewers: labath, zturner, clayborg.
Ilod added a subscriber: lldb-commits.
Fix the windows build after r285702.
The removal of TimeValue.h inclusion removed the inner inclusion of PosixApi.h,
which defined PATH_MAX on windows, used by many other files.
Add
There is no new failure in the tests in Debug version on MSVC 2015, however
a bunch of failures (~30) were masked on Release builds (the Test Methods
count went from 769 to 1188). All the failures were already presents in the
Debug builds (where the optimizer didn't mess up with the code due to
LLV
Ilod updated this revision to Diff 75426.
Ilod added a comment.
Yeah, you're right, the previous code is used for reference was inconsistent
here. Now I return false and set an error string. Also remove an hacky ifdef
which was needed on previous implementation (because the master id was updated
Ilod created this revision.
Ilod added reviewers: zturner, carlokok.
Ilod added a subscriber: lldb-commits.
Since r278177, the Posix functions in PseudoTerminal::OpenFirstAvailableMaster
on windows are now inlined LLVM_UNREACHABLE instead of return 0.
This causes __assume(0) to be inlined in Open
