[Lldb-commits] [lldb] r314458 - [Expression parser] Setting to enable use of ExternalASTMerger

2017-09-28 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 28 13:20:25 2017 New Revision: 314458 URL: http://llvm.org/viewvc/llvm-project?rev=314458=rev Log: [Expression parser] Setting to enable use of ExternalASTMerger This setting can be enabled like this at the target level: (lldb) settings set

[Lldb-commits] [lldb] r314225 - [Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks

2017-09-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Sep 26 10:25:34 2017 New Revision: 314225 URL: http://llvm.org/viewvc/llvm-project?rev=314225=rev Log: [Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks The IR dynamic checks are self-contained functions whose job is to - verify that

[Lldb-commits] [lldb] r309714 - xfail test_get_process_info pending bot fixes

2017-08-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Aug 1 10:43:54 2017 New Revision: 309714 URL: http://llvm.org/viewvc/llvm-project?rev=309714=rev Log: xfail test_get_process_info pending bot fixes Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py Modified:

[Lldb-commits] [lldb] r309702 - [build system] Add SBProcessInfo to the xcodeproj

2017-08-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Aug 1 10:08:46 2017 New Revision: 309702 URL: http://llvm.org/viewvc/llvm-project?rev=309702=rev Log: [build system] Add SBProcessInfo to the xcodeproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r309631 - [build-script] Bring in modernizations from downstream:

2017-07-31 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jul 31 14:50:00 2017 New Revision: 309631 URL: http://llvm.org/viewvc/llvm-project?rev=309631=rev Log: [build-script] Bring in modernizations from downstream: - Don't do any checks of the current SCM repository if the llvm repositories are already there. Useful for

[Lldb-commits] [lldb] r308993 - [TypeSystem] Guard the global `ASTSourceMap` with a mutex

2017-07-25 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 25 10:33:37 2017 New Revision: 308993 URL: http://llvm.org/viewvc/llvm-project?rev=308993=rev Log: [TypeSystem] Guard the global `ASTSourceMap` with a mutex s_source_map in ClangExternalASTSourceCommon.cpp is unguarded and therefore can break in multithreaded

[Lldb-commits] [lldb] r308919 - Skip test_lldbmi_var_update on Darwin.

2017-07-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jul 24 13:11:20 2017 New Revision: 308919 URL: http://llvm.org/viewvc/llvm-project?rev=308919=rev Log: Skip test_lldbmi_var_update on Darwin. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py Modified:

[Lldb-commits] [lldb] r306611 - Added a project for the unified IR interpreter.

2017-06-28 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Jun 28 15:51:16 2017 New Revision: 306611 URL: http://llvm.org/viewvc/llvm-project?rev=306611=rev Log: Added a project for the unified IR interpreter. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

[Lldb-commits] [lldb] r306460 - [build system] If there's an OVERRIDE, don't guess the current SCM.

2017-06-27 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jun 27 13:35:53 2017 New Revision: 306460 URL: http://llvm.org/viewvc/llvm-project?rev=306460=rev Log: [build system] If there's an OVERRIDE, don't guess the current SCM. This makes automatic checkout work even in situations where the current repository can't be

[Lldb-commits] [lldb] r306180 - Updated the NSArray and NSDictionary formatters to support new storage formats.

2017-06-23 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Jun 23 18:15:03 2017 New Revision: 306180 URL: http://llvm.org/viewvc/llvm-project?rev=306180=rev Log: Updated the NSArray and NSDictionary formatters to support new storage formats. Also un-xfailed a testcase that was affected by this. Thanks to Jason Molenda for the

[Lldb-commits] [lldb] r305727 - Updated NSNumber formatter for new internal representation.

2017-06-19 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jun 19 13:32:22 2017 New Revision: 305727 URL: http://llvm.org/viewvc/llvm-project?rev=305727=rev Log: Updated NSNumber formatter for new internal representation. Modified:

[Lldb-commits] [lldb] r305424 - [testsuite] xfailed two tests that depend on NSString conforming to NSCopying.

2017-06-14 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Jun 14 18:01:43 2017 New Revision: 305424 URL: http://llvm.org/viewvc/llvm-project?rev=305424=rev Log: [testsuite] xfailed two tests that depend on NSString conforming to NSCopying. NSString is loaded from the DWARF, which doesn't have the concept of protocols. When this

[Lldb-commits] [lldb] r304510 - [TypeSystem] Handle Clang AttributedTypes

2017-06-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 1 20:24:18 2017 New Revision: 304510 URL: http://llvm.org/viewvc/llvm-project?rev=304510=rev Log: [TypeSystem] Handle Clang AttributedTypes When parsing types originating in modules, it is possible to encounter AttributedTypes (such as the type generated for

[Lldb-commits] [lldb] r304314 - Added a testcase for local/namespaced name conflicts.

2017-05-31 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed May 31 12:18:10 2017 New Revision: 304314 URL: http://llvm.org/viewvc/llvm-project?rev=304314=rev Log: Added a testcase for local/namespaced name conflicts. This works on SVN but is a bit fragile on the Swift branch. I'm adding the test to both, so we have this path

[Lldb-commits] [lldb] r303223 - [Expression parser] Look up module symbols before hunting globally

2017-05-16 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue May 16 18:46:13 2017 New Revision: 303223 URL: http://llvm.org/viewvc/llvm-project?rev=303223=rev Log: [Expression parser] Look up module symbols before hunting globally When it resolves symbol-only variables, the expression parser currently looks only in the global

[Lldb-commits] [lldb] r303110 - [TypeSystem] Fix inspection of Objective-C object types

2017-05-15 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon May 15 14:55:20 2017 New Revision: 303110 URL: http://llvm.org/viewvc/llvm-project?rev=303110=rev Log: [TypeSystem] Fix inspection of Objective-C object types ptr_refs exposed a problem in ClangASTContext's implementation: it uses an accessor to downcast a QualType to an

[Lldb-commits] [lldb] r302954 - Fixed the OS X build after Error -> Status rename.

2017-05-12 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri May 12 16:53:44 2017 New Revision: 302954 URL: http://llvm.org/viewvc/llvm-project?rev=302954=rev Log: Fixed the OS X build after Error -> Status rename. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r302850 - xfail TestClassTemplateParameterPack on gcc to mollify lldb-x86_64-ubuntu-14.04-cmake.

2017-05-11 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu May 11 18:38:21 2017 New Revision: 302850 URL: http://llvm.org/viewvc/llvm-project?rev=302850=rev Log: xfail TestClassTemplateParameterPack on gcc to mollify lldb-x86_64-ubuntu-14.04-cmake. Modified:

[Lldb-commits] [lldb] r302833 - [DWARF parser] Produce correct template parameter packs

2017-05-11 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu May 11 17:08:05 2017 New Revision: 302833 URL: http://llvm.org/viewvc/llvm-project?rev=302833=rev Log: [DWARF parser] Produce correct template parameter packs Templates can end in parameter packs, like this template struct MyStruct { /*...*/ }; LLDB does not

[Lldb-commits] [lldb] r301993 - Fixed a bug where we did not properly use the complete versions of Objective-C classes.

2017-05-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue May 2 19:41:43 2017 New Revision: 301993 URL: http://llvm.org/viewvc/llvm-project?rev=301993=rev Log: Fixed a bug where we did not properly use the complete versions of Objective-C classes. Also added a test case, thanks to Greg Clayton. Added:

[Lldb-commits] [lldb] r301461 - Fixed a crash when dealing with an empty method name in the ObjC runtime.

2017-04-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Apr 26 15:36:47 2017 New Revision: 301461 URL: http://llvm.org/viewvc/llvm-project?rev=301461=rev Log: Fixed a crash when dealing with an empty method name in the ObjC runtime. I've filed a bug covering better unit testing of our runtime metadata reader, which will allow

[Lldb-commits] [lldb] r301280 - Name the C++ source files for two tests correctly.

2017-04-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Apr 24 18:58:36 2017 New Revision: 301280 URL: http://llvm.org/viewvc/llvm-project?rev=301280=rev Log: Name the C++ source files for two tests correctly. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/main.cpp - copied, changed from

[Lldb-commits] [lldb] r301277 - Fixed two bad Makefiles that might be breaking Linux.

2017-04-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Apr 24 18:49:06 2017 New Revision: 301277 URL: http://llvm.org/viewvc/llvm-project?rev=301277=rev Log: Fixed two bad Makefiles that might be breaking Linux. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/Makefile

[Lldb-commits] [lldb] r301273 - [Expression parser] Return both types and variables

2017-04-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Apr 24 18:14:04 2017 New Revision: 301273 URL: http://llvm.org/viewvc/llvm-project?rev=301273=rev Log: [Expression parser] Return both types and variables Many times a user wants to access a type when there's a variable of the same name, or a variable when there's a type

[Lldb-commits] [lldb] r301263 - [DWARF] Fix lookup in the abstract origins of inlined blocks/functions

2017-04-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Apr 24 17:11:10 2017 New Revision: 301263 URL: http://llvm.org/viewvc/llvm-project?rev=301263=rev Log: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions LLDB uses clang::DeclContexts for lookups, and variables get put into the DeclContext for their

[Lldb-commits] [lldb] r300862 - Changed a use of APInt::getSignBit to APInt::getSignMask.

2017-04-20 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Apr 20 13:07:51 2017 New Revision: 300862 URL: http://llvm.org/viewvc/llvm-project?rev=300862=rev Log: Changed a use of APInt::getSignBit to APInt::getSignMask. Modified: lldb/trunk/source/Core/Scalar.cpp Modified: lldb/trunk/source/Core/Scalar.cpp URL:

[Lldb-commits] [lldb] r299587 - The darwin_log tests are very fragile and currently do not properly assess the state of that functionality.

2017-04-05 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Apr 5 15:33:39 2017 New Revision: 299587 URL: http://llvm.org/viewvc/llvm-project?rev=299587=rev Log: The darwin_log tests are very fragile and currently do not properly assess the state of that functionality. I have put them all in their own category, and made that

[Lldb-commits] [lldb] r299402 - Add CPlusPlusNameParser to the xcodeproj

2017-04-03 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Apr 3 18:56:41 2017 New Revision: 299402 URL: http://llvm.org/viewvc/llvm-project?rev=299402=rev Log: Add CPlusPlusNameParser to the xcodeproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [lldb] r298189 - Remove some dead code from DumpValueObjectOptions::PointerDepth

2017-03-29 Thread Sean Callanan via lldb-commits
This is not dead code in Swift-enabled LLDB, as I just found out doing a merge. I'm going to use Default and see what breaks. Sean > On Mar 18, 2017, at 10:33 AM, Tamas Berghammer via lldb-commits > wrote: > > Author: tberghammer > Date: Sat Mar 18 12:33:00 2017

[Lldb-commits] [lldb] r299020 - Move the definition of SBListener::GetSP() to SBListener.cpp.

2017-03-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Mar 29 14:32:59 2017 New Revision: 299020 URL: http://llvm.org/viewvc/llvm-project?rev=299020=rev Log: Move the definition of SBListener::GetSP() to SBListener.cpp. This is the requirement for all functions in the public API, to eliminate weak symbol definitions.

Re: [Lldb-commits] [lldb] r297139 - Revert "Use LLVM for all stat-related functionality."

2017-03-07 Thread Sean Callanan via lldb-commits
Thanks, Pavel. I think if we do this again we should indirect the new API through the LLDB FileSpec API or at least a global function somewhere in LLDB, so that we can change implementations without having to touch so much source code. Sean > On Mar 7, 2017, at 5:19 AM, Pavel Labath via

[Lldb-commits] [lldb] r297128 - Fixed a missing brace.

2017-03-07 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Mar 7 02:31:41 2017 New Revision: 297128 URL: http://llvm.org/viewvc/llvm-project?rev=297128=rev Log: Fixed a missing brace. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp Modified:

[Lldb-commits] [lldb] r296963 - Project file fixes after movement of Data* and removal of ThisThread.cpp

2017-03-04 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Sat Mar 4 02:05:54 2017 New Revision: 296963 URL: http://llvm.org/viewvc/llvm-project?rev=296963=rev Log: Project file fixes after movement of Data* and removal of ThisThread.cpp Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r296951 - Disable the lldb-mi tests on remote platforms.

2017-03-03 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Mar 3 19:48:43 2017 New Revision: 296951 URL: http://llvm.org/viewvc/llvm-project?rev=296951=rev Log: Disable the lldb-mi tests on remote platforms. Currently on remote platforms the lldb-mi tests fail, which means they time out. Given how many of the lldb-mi tests

[Lldb-commits] [lldb] r296924 - Fixed repo.py to not send git errors to stderr.

2017-03-03 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Mar 3 17:13:30 2017 New Revision: 296924 URL: http://llvm.org/viewvc/llvm-project?rev=296924=rev Log: Fixed repo.py to not send git errors to stderr. Some repos are not git repos, so git is expected to fail. These errors should not go to stderr, because Xcode

Re: [Lldb-commits] [lldb] r295897 - Changed builld-llvm.py to use .json files

2017-02-22 Thread Sean Callanan via lldb-commits
data .done Committing transaction... Committed revision 295922. Please let me know if you see any problems. Sean > On Feb 22, 2017, at 4:56 PM, Sean Callanan via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > I'll roll it back pending some fixes on my end. >

[Lldb-commits] [lldb] r295915 - Reverted 295897 pending refinements and fixes for green-dragon.

2017-02-22 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Feb 22 18:46:30 2017 New Revision: 295915 URL: http://llvm.org/viewvc/llvm-project?rev=295915=rev Log: Reverted 295897 pending refinements and fixes for green-dragon. Removed: lldb/trunk/scripts/Xcode/repo.py lldb/trunk/scripts/Xcode/repos/ Modified:

Re: [Lldb-commits] [lldb] r295897 - Changed builld-llvm.py to use .json files

2017-02-22 Thread Sean Callanan via lldb-commits
e a look at the failures here? > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console > <http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console> > > Thanks! > -Tim > > > On Wed, Feb 22, 2017 at 2:57 PM, Sean

[Lldb-commits] [lldb] r295522 - Updated the results formatter to eliminate redundant data.

2017-02-17 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Feb 17 19:07:51 2017 New Revision: 295522 URL: http://llvm.org/viewvc/llvm-project?rev=295522=rev Log: Updated the results formatter to eliminate redundant data. The testsuite's results formatter maintains a result_status_counts structure solely for the purpose of

[Lldb-commits] [lldb] r293161 - Removed an unneccesary #if now that debugserver-mini links Foundation.

2017-01-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jan 26 02:51:32 2017 New Revision: 293161 URL: http://llvm.org/viewvc/llvm-project?rev=293161=rev Log: Removed an unneccesary #if now that debugserver-mini links Foundation. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified:

[Lldb-commits] [lldb] r293098 - Link debugserver against Foundation to get access to NSProcessInfo.

2017-01-25 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Jan 25 15:32:00 2017 New Revision: 293098 URL: http://llvm.org/viewvc/llvm-project?rev=293098=rev Log: Link debugserver against Foundation to get access to NSProcessInfo. debugserver-mini can't use Foundation so disable that code there. Modified:

[Lldb-commits] [lldb] r293022 - Reverted 292880 to fix a linker error.

2017-01-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jan 24 23:39:14 2017 New Revision: 293022 URL: http://llvm.org/viewvc/llvm-project?rev=293022=rev Log: Reverted 292880 to fix a linker error. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r293020 - Conditionalized OsLogger.cpp on a modern SDK.

2017-01-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jan 24 23:18:32 2017 New Revision: 293020 URL: http://llvm.org/viewvc/llvm-project?rev=293020=rev Log: Conditionalized OsLogger.cpp on a modern SDK. Modified: lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp Modified:

[Lldb-commits] [lldb] r290282 - specify -DNDEBUG for BNI builds of all targets in the Xcode build

2016-12-21 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Dec 21 17:21:11 2016 New Revision: 290282 URL: http://llvm.org/viewvc/llvm-project?rev=290282=rev Log: specify -DNDEBUG for BNI builds of all targets in the Xcode build Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r289711 - Adopt PrettyStackTrace in LLDB

2016-12-14 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Dec 14 15:31:31 2016 New Revision: 289711 URL: http://llvm.org/viewvc/llvm-project?rev=289711=rev Log: Adopt PrettyStackTrace in LLDB LLDB needs some minor changes to adopt PrettyStackTrace after https://reviews.llvm.org/D27683. We remove our own SetCrashDescription()

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
It'll be a fix. ETA 10 minutes. > >> On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> >> It's definitely this one. I'll have a fix or a revert in the next 30 >&g

[Lldb-commits] [lldb] r288403 - Handle empty strings when looking for a CFString's encoding.

2016-12-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Dec 1 13:14:55 2016 New Revision: 288403 URL: http://llvm.org/viewvc/llvm-project?rev=288403=rev Log: Handle empty strings when looking for a CFString's encoding. Should fix the bots. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
It'll be a fix. ETA 10 minutes. > On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > It's definitely this one. I'll have a fix or a revert in the next 30 minutes. >> On Dec 1, 2016, at 10:58 AM, Tim Hamme

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
's possible the failure was introduced by either this > commit (r288386) or possibly r288372. > > -Tim > > > On Thu, Dec 1, 2016 at 9:46 AM, Sean Callanan via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > Author: spyf

[Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Dec 1 11:46:51 2016 New Revision: 288386 URL: http://llvm.org/viewvc/llvm-project?rev=288386=rev Log: Handle UTF-16 and UTF-32 constant CFStrings We have a longstanding issue where the expression parser does not handle wide CFStrings (e.g., @"凸凹") correctly, producing

[Lldb-commits] [lldb] r284674 - Added a decorator for the macOS version and switched over testcases that used platform.release

2016-10-19 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Oct 19 19:03:39 2016 New Revision: 284674 URL: http://llvm.org/viewvc/llvm-project?rev=284674=rev Log: Added a decorator for the macOS version and switched over testcases that used platform.release Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py

[Lldb-commits] [lldb] r283904 - Clarified the explanation of expr --top-level.

2016-10-11 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Oct 11 11:57:21 2016 New Revision: 283904 URL: http://llvm.org/viewvc/llvm-project?rev=283904=rev Log: Clarified the explanation of expr --top-level. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp Modified:

[Lldb-commits] [lldb] r283604 - Remove a stray dump().

2016-10-07 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Oct 7 16:25:29 2016 New Revision: 283604 URL: http://llvm.org/viewvc/llvm-project?rev=283604=rev Log: Remove a stray dump(). Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp URL:

[Lldb-commits] [lldb] r282943 - Adding ivars in class extensions isn't supported on i386; skip a test.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 15:46:09 2016 New Revision: 282943 URL: http://llvm.org/viewvc/llvm-project?rev=282943=rev Log: Adding ivars in class extensions isn't supported on i386; skip a test. Modified:

[Lldb-commits] [lldb] r282898 - Fixed several i386 Objective-C tests by completing objects, not their pointers.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 13:44:43 2016 New Revision: 282898 URL: http://llvm.org/viewvc/llvm-project?rev=282898=rev Log: Fixed several i386 Objective-C tests by completing objects, not their pointers. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r282869 - Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars.

2016-09-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 30 11:02:28 2016 New Revision: 282869 URL: http://llvm.org/viewvc/llvm-project?rev=282869=rev Log: Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars. Modified:

[Lldb-commits] [lldb] r282794 - Don't expect new-style Objective-C literals to work on i386 with the V1 runtime.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 17:01:11 2016 New Revision: 282794 URL: http://llvm.org/viewvc/llvm-project?rev=282794=rev Log: Don't expect new-style Objective-C literals to work on i386 with the V1 runtime. Modified:

[Lldb-commits] [lldb] r282787 - Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 16:43:31 2016 New Revision: 282787 URL: http://llvm.org/viewvc/llvm-project?rev=282787=rev Log: Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2. Modified:

[Lldb-commits] [lldb] r282741 - To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 12:57:33 2016 New Revision: 282741 URL: http://llvm.org/viewvc/llvm-project?rev=282741=rev Log: To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64. Modified:

[Lldb-commits] [lldb] r282653 - Introduced a null check to avoid a crash in a test on i386.

2016-09-28 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 28 19:16:37 2016 New Revision: 282653 URL: http://llvm.org/viewvc/llvm-project?rev=282653=rev Log: Introduced a null check to avoid a crash in a test on i386. Modified: lldb/trunk/source/Target/StackFrame.cpp Modified: lldb/trunk/source/Target/StackFrame.cpp

[Lldb-commits] [lldb] r282434 - Added a setting that enables saving all .o files from a given JIT expression.

2016-09-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Sep 26 15:18:51 2016 New Revision: 282434 URL: http://llvm.org/viewvc/llvm-project?rev=282434=rev Log: Added a setting that enables saving all .o files from a given JIT expression. This allows debugging of the JIT and other analyses of the internals of the expression

[Lldb-commits] [lldb] r281943 - Fixed the build by changing a couple of const char *s to StringRefs.

2016-09-19 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Sep 19 17:06:12 2016 New Revision: 281943 URL: http://llvm.org/viewvc/llvm-project?rev=281943=rev Log: Fixed the build by changing a couple of const char *s to StringRefs. Modified: lldb/trunk/source/Host/macosx/Host.mm

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Sean Callanan via lldb-commits
How different is that really from (lldb) script lldb.frame.FindVariable("argc").GetValue() '1' (lldb) script lldb.process.GetNumThreads() 1 (lldb) script lldb.process.GetThreadAtIndex(0).GetThreadID() 3514809 ? If it's developer-only, then this is even fairly well-documented using e.g. "script

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Sean Callanan via lldb-commits
spyffe added a subscriber: spyffe. spyffe added a comment. I like this concept a lot, and I think it's great for testcases that actually need to interact with the command line. I'm concerned, though, that the separation of input from command files makes tests more complex to write. One thing

[Lldb-commits] [lldb] r281545 - More cleanup in `frame diagnose, ` eliminating a bunch of messy cases.

2016-09-14 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 14 16:54:28 2016 New Revision: 281545 URL: http://llvm.org/viewvc/llvm-project?rev=281545=rev Log: More cleanup in `frame diagnose,` eliminating a bunch of messy cases. Modified: lldb/trunk/include/lldb/Core/Disassembler.h

[Lldb-commits] [lldb] r281536 - Replaced two instances of std::function with auto.

2016-09-14 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 14 15:58:31 2016 New Revision: 281536 URL: http://llvm.org/viewvc/llvm-project?rev=281536=rev Log: Replaced two instances of std::function with auto. Thanks to Zachary Turner for the suggestion. It's distasteful that the actual type of the lambda can't be spelled

Re: [Lldb-commits] [lldb] r281534 - Cleaned up a little bit of redundant code in 'frame diagnose.`

2016-09-14 Thread Sean Callanan via lldb-commits
Okay, one sec. Sean > On Sep 14, 2016, at 1:40 PM, Zachary Turner <ztur...@google.com> wrote: > > > > On Wed, Sep 14, 2016 at 1:38 PM Sean Callanan via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > >

[Lldb-commits] [lldb] r281534 - Cleaned up a little bit of redundant code in 'frame diagnose.`

2016-09-14 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 14 15:29:57 2016 New Revision: 281534 URL: http://llvm.org/viewvc/llvm-project?rev=281534=rev Log: Cleaned up a little bit of redundant code in 'frame diagnose.` Modified: lldb/trunk/source/Target/StackFrame.cpp Modified: lldb/trunk/source/Target/StackFrame.cpp

[Lldb-commits] [lldb] r281428 - Cleaned up the code that handles function return addresses in "frame diagnose."

2016-09-13 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Sep 13 19:48:19 2016 New Revision: 281428 URL: http://llvm.org/viewvc/llvm-project?rev=281428=rev Log: Cleaned up the code that handles function return addresses in "frame diagnose." Modified: lldb/trunk/source/Target/StackFrame.cpp Modified:

[Lldb-commits] [lldb] r281398 - Cleaned up some of the "frame diagnose" code to use Operands as currency.

2016-09-13 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Sep 13 16:18:27 2016 New Revision: 281398 URL: http://llvm.org/viewvc/llvm-project?rev=281398=rev Log: Cleaned up some of the "frame diagnose" code to use Operands as currency. Also added some utility functions around Operands to make code easier and more compact to

[Lldb-commits] [lldb] r280692 - Added the "frame diagnose" command and use its output to make crash info better.

2016-09-05 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Sep 5 23:48:36 2016 New Revision: 280692 URL: http://llvm.org/viewvc/llvm-project?rev=280692=rev Log: Added the "frame diagnose" command and use its output to make crash info better. When a process stops due to a crash, we get the crashing instruction and the crashing

[Lldb-commits] [lldb] r279896 - Fixed the location of a conditional to make the following code clearer.

2016-08-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Aug 26 19:35:37 2016 New Revision: 279896 URL: http://llvm.org/viewvc/llvm-project?rev=279896=rev Log: Fixed the location of a conditional to make the following code clearer. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

[Lldb-commits] [lldb] r279894 - The error stream in IRForTarget is never null, so use it instead of the log.

2016-08-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Aug 26 19:20:38 2016 New Revision: 279894 URL: http://llvm.org/viewvc/llvm-project?rev=279894=rev Log: The error stream in IRForTarget is never null, so use it instead of the log. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

[Lldb-commits] [lldb] r279884 - Fixed a bad lldbassert() condition.

2016-08-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Aug 26 18:48:03 2016 New Revision: 279884 URL: http://llvm.org/viewvc/llvm-project?rev=279884=rev Log: Fixed a bad lldbassert() condition. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified:

[Lldb-commits] [lldb] r279850 - Don't crash when trying to capture persistent variables in a block.

2016-08-26 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Aug 26 13:12:39 2016 New Revision: 279850 URL: http://llvm.org/viewvc/llvm-project?rev=279850=rev Log: Don't crash when trying to capture persistent variables in a block. Reports an error instead. We can fix this later to make persistent variables work, but right now we

Re: [Lldb-commits] [PATCH] D21328: [lldb] Fixed incorrect endianness when evaluating certain expressions

2016-07-25 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. This looks fine. How tricky would it be to make a test case for a reproduction scenario? https://reviews.llvm.org/D21328 ___

[Lldb-commits] [lldb] r275652 - Fixed the location of the Swift bindings in the Xcode build.

2016-07-15 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Jul 15 19:18:24 2016 New Revision: 275652 URL: http://llvm.org/viewvc/llvm-project?rev=275652=rev Log: Fixed the location of the Swift bindings in the Xcode build. $BUILT_PRODUCTS_DIR is usually the same as $CONFIGURATION_BUILD_DIR, but differs when LLDB is being built

Re: [Lldb-commits] [lldb] r275223 - Mark TagDecls as having external visible storage, like ContainerDecls.

2016-07-12 Thread Sean Callanan via lldb-commits
t; On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >> Author: spyffe >> Date: Tue Jul 12 17:42:07 2016 >> New Revision: 275223 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=275223=

[Lldb-commits] [lldb] r275237 - Revert r275223, which committed the wrong thing.

2016-07-12 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 12 18:31:42 2016 New Revision: 275237 URL: http://llvm.org/viewvc/llvm-project?rev=275237=rev Log: Revert r275223, which committed the wrong thing. Modified: lldb/trunk/lldb.xcworkspace/contents.xcworkspacedata Modified:

Re: [Lldb-commits] [lldb] r275223 - Mark TagDecls as having external visible storage, like ContainerDecls.

2016-07-12 Thread Sean Callanan via lldb-commits
Argh, this isn’t what I wanted to commit AT ALL. Sorry folks. I’ll fix this momentarily. Thanks to Jim Ingham for pointing it out. Sean > On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: spyffe > Date: Tue

[Lldb-commits] [lldb] r275223 - Mark TagDecls as having external visible storage, like ContainerDecls.

2016-07-12 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 12 17:42:07 2016 New Revision: 275223 URL: http://llvm.org/viewvc/llvm-project?rev=275223=rev Log: Mark TagDecls as having external visible storage, like ContainerDecls. The lookup tables can get out of date during the lifetime of the object so we need to preserve

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-07-11 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. I'm concerned about the performance implications here, because `FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just for ones that would fail unless we did

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

2016-07-11 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Yes, we should follow the same rules as in regular lookup for these contexts. If the test suite is happy here, I'm happy. http://reviews.llvm.org/D13350

Re: [Lldb-commits] [PATCH] D15116: Fix for evaluating a function with an ambiguous symbol

2016-07-11 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Sorry for getting to this review so late. This looks all right, and pretty conservative. As long as the test suite is okay with it, this looks fine! Thanks for the test case, too.

Re: [Lldb-commits] [PATCH] D11270: Expr evaluation - Avoid to check when the memory handle is zero

2016-07-11 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. This code has been eliminated as -part of a refactoring of the way IRForTarget works. I'm sorry that I didn't get to this review earlier, but at this point the patch probably isn't

[Lldb-commits] [lldb] r274580 - Fixed a bug where we report a single type multiple times in namespaces.

2016-07-05 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jul 5 17:06:01 2016 New Revision: 274580 URL: http://llvm.org/viewvc/llvm-project?rev=274580=rev Log: Fixed a bug where we report a single type multiple times in namespaces. Also added a testcase. Added:

[Lldb-commits] [lldb] r274254 - Removed the redundant "%d errors parsing expression" error. Nobody keeps score.

2016-06-30 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 30 13:00:32 2016 New Revision: 274254 URL: http://llvm.org/viewvc/llvm-project?rev=274254=rev Log: Removed the redundant "%d errors parsing expression" error. Nobody keeps score. Modified:

[Lldb-commits] [lldb] r273718 - Added a test case for bitfield ivars. It currently fails.

2016-06-24 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Jun 24 15:41:18 2016 New Revision: 273718 URL: http://llvm.org/viewvc/llvm-project?rev=273718=rev Log: Added a test case for bitfield ivars. It currently fails. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/

[Lldb-commits] [lldb] r273632 - Handle variadic Objective-C methods from DWARF correctly.

2016-06-23 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 23 19:24:40 2016 New Revision: 273632 URL: http://llvm.org/viewvc/llvm-project?rev=273632=rev Log: Handle variadic Objective-C methods from DWARF correctly. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/variadic_methods/

[Lldb-commits] [lldb] r273622 - Don't run the top-level expression test case with -gmodules.

2016-06-23 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 23 17:18:08 2016 New Revision: 273622 URL: http://llvm.org/viewvc/llvm-project?rev=273622=rev Log: Don't run the top-level expression test case with -gmodules. Modified:

[Lldb-commits] [lldb] r273211 - Test that lldb calls the right 'printf' even when a 'printf' method exists.

2016-06-20 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Jun 20 18:01:11 2016 New Revision: 273211 URL: http://llvm.org/viewvc/llvm-project?rev=273211=rev Log: Test that lldb calls the right 'printf' even when a 'printf' method exists. This test is currently failing. We have a bug for it, as noted. Added:

[Lldb-commits] [lldb] r272320 - Fixed a problem in IRMemoryMap where the flag to zero out memory was ignored.

2016-06-09 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 9 17:22:40 2016 New Revision: 272320 URL: http://llvm.org/viewvc/llvm-project?rev=272320=rev Log: Fixed a problem in IRMemoryMap where the flag to zero out memory was ignored. Modified: lldb/trunk/source/Expression/IRMemoryMap.cpp Modified:

[Lldb-commits] [lldb] r272301 - Updated the FindSpace() algorithm to avoid the 0 page when it's unsafe.

2016-06-09 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 9 15:22:25 2016 New Revision: 272301 URL: http://llvm.org/viewvc/llvm-project?rev=272301=rev Log: Updated the FindSpace() algorithm to avoid the 0 page when it's unsafe. Previously we eliminated the randomized scheme for finding memory when the underlying process

[Lldb-commits] [PATCH] D21152: Hunt for unused memory properly when dealing with processes that can tell us about memory mappings

2016-06-08 Thread Sean Callanan via lldb-commits
spyffe created this revision. spyffe added reviewers: tfiala, clayborg. spyffe added a subscriber: lldb-commits. spyffe set the repository for this revision to rL LLVM. Right now the default initial address is 0x0, which is very problematic on embedded targets where that's the CPU's

[Lldb-commits] [lldb] r272024 - Make lldbinline.py regenerate the Makefile each time it builds.

2016-06-07 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jun 7 12:22:18 2016 New Revision: 272024 URL: http://llvm.org/viewvc/llvm-project?rev=272024=rev Log: Make lldbinline.py regenerate the Makefile each time it builds. If a lldbinline test's source file changed language, then the Makefile wasn't updated. This was a

[Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

2016-06-06 Thread Sean Callanan via lldb-commits
spyffe created this revision. spyffe added a reviewer: tfiala. spyffe added a subscriber: lldb-commits. spyffe set the repository for this revision to rL LLVM. To eliminate problems where 'lldbinline.py'-generated Makefiles are re-used, I've standardized the generation of them. The testsuite

[Lldb-commits] [lldb] r271551 - Fixed a problem where we couldn't call extern "C" functions.

2016-06-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Jun 2 12:59:47 2016 New Revision: 271551 URL: http://llvm.org/viewvc/llvm-project?rev=271551=rev Log: Fixed a problem where we couldn't call extern "C" functions. Some compilers do not mark up C++ functions as extern "C" in the DWARF, so LLDB has to fall back (if it is

[Lldb-commits] [lldb] r269698 - Test diamond virtual inheritance in top-level expressions.

2016-05-16 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon May 16 15:55:10 2016 New Revision: 269698 URL: http://llvm.org/viewvc/llvm-project?rev=269698=rev Log: Test diamond virtual inheritance in top-level expressions. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/test.cpp Modified:

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

2016-05-09 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. This patch is fine. I especially appreciate the time you took making the IRInterpreter properly testable. I will use this myself. Comment at:

[Lldb-commits] [lldb] r268559 - Intentionally leak the ASTSourceMap instead of destroying it when LLDB quits.

2016-05-04 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed May 4 16:42:55 2016 New Revision: 268559 URL: http://llvm.org/viewvc/llvm-project?rev=268559=rev Log: Intentionally leak the ASTSourceMap instead of destroying it when LLDB quits. Modified: lldb/trunk/source/Symbol/ClangExternalASTSourceCommon.cpp Modified:

  1   2   3   >