[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

saugustine added a comment. What other progress reporting needs rate limiting? To the best of my knowledge, we have only identified one location--this one. So I'm not sure a fully general solution is in order here under the YAGNI principle. I favor rate limiting close to the source because

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine added a comment. In D150805#4397940 , @rupprecht wrote: > In D150805#4350849 , @JDevlieghere > wrote: > >> I also like Jordan's rate limiting idea. In my mind that should be a >> property of the

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine abandoned this revision. saugustine added a comment. I'll let someone with a better understanding of the proper implementation take it from here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine added a comment. Any more thoughts on this from the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523951. saugustine added a comment. Moved the rate-limiting to Debugger.[cpp|h] Also wrote a custom getCurrentTime function, which doesn't do the much of the extra work the Timer.h version does. With this change, the timing is much better: On my local

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine added a comment. This update switches to a time-based approach as suggested by Jordan. However, the timing is about the same as the original. I believe because calling getCurrentTime every iteration is comparably slow as printing the progress report itself. It probably is still a

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523191. saugustine added a comment. Switch rate-limiting to a time-based mechanism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 Files:

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523188. saugustine added a comment. Swtich rate-limiting to a time-based mechanism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 Files:

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine created this revision. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. saugustine requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reporting progress for every DIE read turns out to be very slow

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

saugustine added a comment. Thanks for the quick fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144228/new/ https://reviews.llvm.org/D144228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

saugustine added a comment. I don't think this necessarily matters or is a reason to revert, but we are seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. The docs claim that versions past 3.0 are supported (except for some odd corner cases). The failure is:

[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

saugustine added a comment. Committed as 5402110e0123ca323a5f6eaa3ed225027ce0179b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143955/new/ https://reviews.llvm.org/D143955

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

saugustine added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

saugustine added a comment. Fix for the variable-sized-array issue in rG7518e0ff63cd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121408/new/ https://reviews.llvm.org/D121408

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7518e0ff63cd: Avoid using a variable-sized array for a tiny allocation. (authored by saugustine). Repository: rG LLVM

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

saugustine created this revision. Herald added a project: All. saugustine requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121732 Files:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

saugustine added a comment. Herald added a subscriber: JDevlieghere. This change uses a variable-sized array, which is c99 only: third_party/llvm/llvm-project/lldb/source/Expression/DWARFExpression.cpp:1300:30: error: variable length arrays are a C99 feature [-Werror,-Wvla-extension]

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. Some people complain if I revert without notification. So I always notify as soon as I find the patch with the problem. Some reverts are more complicated than others too. I guess it adds more noise but I try to default to more communication over less. Repository:

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. Thanks for looking. Reverted with 4e5af6ef48590e7248e344ddabf245bb3de71c51 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. This change breaks various build bots with a missing file. See below. Reverting shortly. For example: https://lab.llvm.org/buildbot/#/builders/68/builds/16816 /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

saugustine added a comment. This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer." I fixed it in

[Lldb-commits] [PATCH] D69143: (NFC) Delete variable made unused by llvm-svn: 375160

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbbbc873f83e4: (NFC) Delete variable made unused by llvm-svn: 375160 (authored by saugustine). Herald added a project:

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

saugustine added a comment. This breaks the build due to lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1355:8: error: unused variable 'old_size' [-Werror,-Wunused-variable] I will check in a fix shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION