sylvestre.ledru added a comment.
Maybe add it to the release notes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137337/new/
https://reviews.llvm.org/D137337
___
lldb-commits mailing list
sylvestre.ledru added a comment.
i hope not too many people rely on it.
LGTM but please add it to the release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125860/new/
https://reviews.llvm.org/D125860
___
lldb-commits mailing list
sylvestre.ledru added a comment.
Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119186/new/
sylvestre.ledru added a comment.
Debian is still broken with this patch on -14:
lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function
lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket():
error: undefined reference to
sylvestre.ledru added a comment.
Seems that it broke apt.llvm.org on ubuntu bionic with Python 3.6:
I reported this issue: https://github.com/llvm/llvm-project/issues/53291
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114722/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG427f6e11e68a: [lldb][docs] Update instructions for building
libc++ (authored by torarnv, committed by sylvestre.ledru).
Repository:
rG LLVM
sylvestre.ledru added a comment.
I will push it for you. What do you want to use as full name + email ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115877/new/
https://reviews.llvm.org/D115877
___
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115877/new/
https://reviews.llvm.org/D115877
sylvestre.ledru added a comment.
> Maybe it would be better to disable the binary completely (in cmake) for
> unsupported architectures instead?
+1, having an error message like "lldb isn't supported on arch foo" would save
hours of work :)
CHANGES SINCE LAST ACTION
sylvestre.ledru added a comment.
This change doesn't build with gcc 5.3.1.
More details: https://bugs.llvm.org/show_bug.cgi?id=48869
It would be great if you have could have a look! thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92759/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43e451f9f316: Fix gendered documentation (authored by
pedro.gonnet, committed by sylvestre.ledru).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78807/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0784e17f1b4a: Remove .svn from exclude list as we moved to
git (authored by sylvestre.ledru).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
sylvestre.ledru added a comment.
ed if you want to approve it ;)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89859/new/
https://reviews.llvm.org/D89859
___
lldb-commits mailing list
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: serge-sans-paille.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny.
Herald added a reviewer: bollu.
Herald added projects: clang, LLDB, LLVM.
sylvestre.ledru requested review of this revision.
Herald
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78807/new/
https://reviews.llvm.org/D78807
sylvestre.ledru added inline comments.
Comment at: lldb/source/Utility/XcodeSDK.cpp:72
+ llvm::VersionTuple version = ParseSDKVersion(input);
+ return {sdk, version};
+}
With older version of the libcstdc++ (some Ubuntu LTS), it fails with:
```
error: chosen
sylvestre.ledru added a comment.
Sure, happy to try, do you have some docs on this? Thanks :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68537/new/
https://reviews.llvm.org/D68537
___
lldb-commits mailing list
sylvestre.ledru added a comment.
@labath
I am building with AVR as experimental target and this change probably broke
the build.
In file included from
sylvestre.ledru added a comment.
On i386
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55434/new/
https://reviews.llvm.org/D55434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sylvestre.ledru added a comment.
@labath This broke lldb on Debian stable:
In file included from
/build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/source/Utility/DataExtractor.cpp:10:
/build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/include/lldb/Utility/DataExtractor.h:1099:29:
sylvestre.ledru added a comment.
This fixed the issue, thanks!
https://reviews.llvm.org/D39246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sylvestre.ledru added a comment.
Like llvm or lldb in general, just integrate it into liblldb?
By the way, liblldb-intel-mpxtable.so-5.0 is incorrect should be
liblldb-intel-mpxtable.so.5.0
Repository:
rL LLVM
https://reviews.llvm.org/D29078
sylvestre.ledru added a comment.
This change is creating a new library
usr/lib/llvm-5.0/bin/liblldb-intel-mpxtable.so on GNU/Linux 64b
That sounds pretty specific, is that really something that we want to do?
Repository:
rL LLVM
https://reviews.llvm.org/D29078
sylvestre.ledru abandoned this revision.
sylvestre.ledru added a comment.
Thanks!
https://reviews.llvm.org/D28155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sylvestre.ledru added a comment.
Probably, I did it the easy way
I don't know what ARG_GENERATE_INSTALL in cmake/modules/AddLLDB.cmake is for
https://reviews.llvm.org/D28155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: beanz.
sylvestre.ledru added a subscriber: LLDB.
Herald added a subscriber: mgorny.
For some reasons, the usage of add_lldb_tool instead of add_lldb_executable
causes these two binaries not be installed.
This patch fixes
26 matches
Mail list logo
