[Lldb-commits] [lldb] r317574 - Fix an issue in r317563 causing a clang assert

2017-11-07 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 7 05:43:55 2017 New Revision: 317574 URL: http://llvm.org/viewvc/llvm-project?rev=317574=rev Log: Fix an issue in r317563 causing a clang assert Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp

[Lldb-commits] [lldb] r317563 - Support scoped enums in the DWARF AST parser

2017-11-07 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 7 02:39:22 2017 New Revision: 317563 URL: http://llvm.org/viewvc/llvm-project?rev=317563=rev Log: Support scoped enums in the DWARF AST parser Subscribers: JDevlieghere Differential Revision: https://reviews.llvm.org/D39545 Modified:

[Lldb-commits] [lldb] r317411 - Improve the posix core file triple detection

2017-11-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Sat Nov 4 11:25:51 2017 New Revision: 317411 URL: http://llvm.org/viewvc/llvm-project?rev=317411=rev Log: Improve the posix core file triple detection Summary: Posix core files sometime don't contain enough information to correctly detect the OS. If that is the case we

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

2017-10-16 Thread Tamas Berghammer via lldb-commits
On linux when you call fork the new process will only have the thread what called fork. Other threads will be ignored with leaving whatever dirty state they had left in the new process. Regarding execve it doesn't do fork so we would have to do fork & execve what have the same issue (actually we

Re: [Lldb-commits] [lldb] r313442 - Fix compatibility with OpenOCD debug stub.

2017-09-18 Thread Tamas Berghammer via lldb-commits
Hi Vadim, This change broke remote debugging on Linux and Android as for some reason LLDB sends a qfThreadInfo on those platforms before starting a process (not sure why, will investigate when I have a bit more time) and lldb-server sends an OK response to it. After your change it will generate a

[Lldb-commits] [lldb] r313525 - Fix Linux remote debugging after r313442

2017-09-18 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Sep 18 03:24:48 2017 New Revision: 313525 URL: http://llvm.org/viewvc/llvm-project?rev=313525=rev Log: Fix Linux remote debugging after r313442 On Linux lldb-server sends an OK response to qfThreadInfo if no process is started yet. I don't know why would LLDB issue

[Lldb-commits] [lldb] r311775 - Add support for the DWP debug info format

2017-08-25 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Aug 25 06:56:14 2017 New Revision: 311775 URL: http://llvm.org/viewvc/llvm-project?rev=311775=rev Log: Add support for the DWP debug info format Summary: The DWP (DWARF package) format is used to pack multiple dwo files generated by split-dwarf into a single ELF

[Lldb-commits] [lldb] r311000 - Remove the DWARFExpression -> Clang ExpressionParser dependency

2017-08-16 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Aug 16 04:45:10 2017 New Revision: 311000 URL: http://llvm.org/viewvc/llvm-project?rev=311000=rev Log: Remove the DWARFExpression -> Clang ExpressionParser dependency It was completly unused and broke the part of the encapsulation that common code shouldn't depend

[Lldb-commits] [lldb] r309554 - Add support for base address entries in the .debug_ranges section

2017-07-31 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 31 03:26:19 2017 New Revision: 309554 URL: http://llvm.org/viewvc/llvm-project?rev=309554=rev Log: Add support for base address entries in the .debug_ranges section Summary: Clang recently started to emit base address entries into the .debug_ranges section to

[Lldb-commits] [lldb] r309265 - XFAIL/XFlakey some tests what become very flakey on the Linux buildbot

2017-07-27 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Jul 27 05:01:32 2017 New Revision: 309265 URL: http://llvm.org/viewvc/llvm-project?rev=309265=rev Log: XFAIL/XFlakey some tests what become very flakey on the Linux buildbot Modified:

[Lldb-commits] [lldb] r299677 - XFAIL TestDataFormatterLibcxxVBool on Linux & Android

2017-04-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Apr 6 13:15:43 2017 New Revision: 299677 URL: http://llvm.org/viewvc/llvm-project?rev=299677=rev Log: XFAIL TestDataFormatterLibcxxVBool on Linux & Android The skipping logic for the test have been fixed recently but the test is very flakey on the buildbot.

[Lldb-commits] [lldb] r299259 - Stop calling ValueObject::SetName from synthetic child providers

2017-03-31 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Mar 31 15:48:00 2017 New Revision: 299259 URL: http://llvm.org/viewvc/llvm-project?rev=299259=rev Log: Stop calling ValueObject::SetName from synthetic child providers Summary: Calling ValueObject::SetName from a sythetic child provider would change the underying

[Lldb-commits] [lldb] r299251 - Add support for sythetic operator dereference

2017-03-31 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Mar 31 15:23:22 2017 New Revision: 299251 URL: http://llvm.org/viewvc/llvm-project?rev=299251=rev Log: Add support for sythetic operator dereference Summary: After this change a sythetic child provider can generate a special child named "$$dereference$$" what if

[Lldb-commits] [lldb] r299249 - Do not dereference std::unique_ptr by default

2017-03-31 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Mar 31 15:07:20 2017 New Revision: 299249 URL: http://llvm.org/viewvc/llvm-project?rev=299249=rev Log: Do not dereference std::unique_ptr by default Summary: Displaying the object pointed by the unique_ptr can cause an infinite recursion when we have a pointer loop

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

2017-03-30 Thread Tamas Berghammer via lldb-commits
Created bug for exposing ValueObject::Clone as SB API: http://bugs.llvm.org/show_bug.cgi?id=32477 On Thu, Mar 30, 2017 at 1:04 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham accepted this revision. > jingham added a comment. > This revision is now accepted and ready

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

2017-03-30 Thread Tamas Berghammer via lldb-commits
It is possible to vend one of the actual backing object as a synthetic child using the SB API. What is not possible from the SB API at the moment (we might want to fix it) is to vend one of the actual backing object with a different name then the underlying object itself. You can still say that

[Lldb-commits] [lldb] r298189 - Remove some dead code from DumpValueObjectOptions::PointerDepth

2017-03-18 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Sat Mar 18 12:33:00 2017 New Revision: 298189 URL: http://llvm.org/viewvc/llvm-project?rev=298189=rev Log: Remove some dead code from DumpValueObjectOptions::PointerDepth Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h

[Lldb-commits] [lldb] r291559 - Improve Type::GetTypeScopeAndBasenameHelper and add unit tests

2017-01-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Jan 10 05:13:59 2017 New Revision: 291559 URL: http://llvm.org/viewvc/llvm-project?rev=291559=rev Log: Improve Type::GetTypeScopeAndBasenameHelper and add unit tests Previously it failed to handle nested types inside templated classes making it impossible to look up

[Lldb-commits] [lldb] r291350 - Fix dereferencing of pointers to empty classes

2017-01-07 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Sat Jan 7 10:39:07 2017 New Revision: 291350 URL: http://llvm.org/viewvc/llvm-project?rev=291350=rev Log: Fix dereferencing of pointers to empty classes Added: lldb/trunk/packages/Python/lldbsuite/test/python_api/value/empty_class/

[Lldb-commits] [lldb] r291349 - Remove an incorrect byte size calculation in DWARFASTParserClang

2017-01-07 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Sat Jan 7 10:39:02 2017 New Revision: 291349 URL: http://llvm.org/viewvc/llvm-project?rev=291349=rev Log: Remove an incorrect byte size calculation in DWARFASTParserClang Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified:

[Lldb-commits] [lldb] r290895 - Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Jan 3 10:29:43 2017 New Revision: 290895 URL: http://llvm.org/viewvc/llvm-project?rev=290895=rev Log: Improve the performance of jModulesInfo in lldb-server Previously it parsed /proc//maps for every module separately resulting in a very slow response time. This CL

[Lldb-commits] [lldb] r286581 - Fix TestHelp on linux after version number syntax change

2016-11-11 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Nov 11 05:39:23 2016 New Revision: 286581 URL: http://llvm.org/viewvc/llvm-project?rev=286581=rev Log: Fix TestHelp on linux after version number syntax change Modified: lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py Modified:

[Lldb-commits] [lldb] r286360 - Fix expectation in TestStaticVariables.py after rL286302

2016-11-09 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Nov 9 05:52:12 2016 New Revision: 286360 URL: http://llvm.org/viewvc/llvm-project?rev=286360=rev Log: Fix expectation in TestStaticVariables.py after rL286302 The debug info emitted by clang for static variables improved by rL286302 and it exposed an incorrect test

Re: [Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

2016-11-08 Thread Tamas Berghammer via lldb-commits
I think the UnwindAssemblyInstEmulation tracks every register without knowing if it is volatile or not and then RegisterContextLLDB will consult with the ABI (during RegisterRead) to decide which registers can it recover (based on volatile/non-volatile). For x86 I think the long term solution

Re: [Lldb-commits] [PATCH] D26338: [lldb] Don't build unit tests for unsupported targets

2016-11-07 Thread Tamas Berghammer via lldb-commits
The problem is that if we reuse the LLVM disassembler (I am not sure if we do it in TestArm64InstEmulation or not but we definitely should) then we need LLVM to be build with support for that specific architecture as otherwise the assembly analysis based unwinding test won't work. On Mon, Nov 7,

[Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

2016-11-04 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. My understanding (can be wrong) is that there IS a difference between not specifying a register in the unwind info versus specifying it as "is same" for volatile (caller saved) registers. I think for volatile registers not specifying them means that we can't access

[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

2016-10-31 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. The patch generally looks good to me. I added a few high level thought about register context but they are clearly out of scope for this change. Also next time please upload your

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

2016-10-21 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Sorry, I missed that part. I just submitted r284831 what should fix the header order for both case. Repository: rL LLVM https://reviews.llvm.org/D25733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r284831 - Fix incorrect header order introduced in rL284830

2016-10-21 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Oct 21 10:05:03 2016 New Revision: 284831 URL: http://llvm.org/viewvc/llvm-project?rev=284831=rev Log: Fix incorrect header order introduced in rL284830 Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

2016-10-21 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284829: Add data formatter for libstdc++ tuple (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D25733?vs=75417=75433#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-21 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284828: Improve the libstdc++ smart pointer formatters (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D25726?vs=75300=75431#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

2016-10-21 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284830: Add data formatter for libstdc++ unique_ptr (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D25734?vs=75425=75432#toc Repository: rL LLVM

[Lldb-commits] [lldb] r284830 - Add data formatter for libstdc++ unique_ptr

2016-10-21 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Oct 21 10:02:44 2016 New Revision: 284830 URL: http://llvm.org/viewvc/llvm-project?rev=284830=rev Log: Add data formatter for libstdc++ unique_ptr Differential revision: https://reviews.llvm.org/D25734 Added:

[Lldb-commits] [lldb] r284829 - Add data formatter for libstdc++ tuple

2016-10-21 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Oct 21 10:02:38 2016 New Revision: 284829 URL: http://llvm.org/viewvc/llvm-project?rev=284829=rev Log: Add data formatter for libstdc++ tuple Differential revision: https://reviews.llvm.org/D25733 Added:

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

2016-10-21 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110 + if (name == ConstString("ptr") || name == ConstString("pointer")) return 2; + return UINT32_MAX; +} labath wrote: > ~0 ? The user compares the

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

2016-10-21 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 75425. tberghammer marked 2 inline comments as done. Herald added subscribers: mgorny, beanz. https://reviews.llvm.org/D25734 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

2016-10-21 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 75417. tberghammer marked 4 inline comments as done. https://reviews.llvm.org/D25733 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile

[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

2016-10-21 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. A few high level comments: - I have the feeling you ported much more code over to use the LLDB register numbers then it would be strictly necessary. I am not sure if it is good or bad as it can help us consolidate the confusion around the different register

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-20 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 75300. tberghammer marked 5 inline comments as done. https://reviews.llvm.org/D25726 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.py

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-20 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138 +return 3; + return UINT32_MAX; +} labath wrote: > I know you just copied it, but this seems wrong (size_t can be 64-bit). Will > this work if

[Lldb-commits] [lldb] r284725 - Re-generate the python and cpp reference documentation

2016-10-20 Thread Tamas Berghammer via lldb-commits
Modified: lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html?rev=284725=284724=284725=diff

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-18 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In https://reviews.llvm.org/D25726#573127, @Eugene.Zelenko wrote: > Please run Clang-format over new code. I run it before upload but it mush have picked up some strange config. Will run it again before submit. Thanks for noticing it.

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

2016-10-18 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Add data formatter for libstdc++ unique_ptr https://reviews.llvm.org/D25734 Files:

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

2016-10-18 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Herald added subscribers: mgorny, beanz. Add data formatter for libstdc++ tuple https://reviews.llvm.org/D25733 Files:

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-18 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 75025. tberghammer added a comment. Herald added subscribers: mgorny, beanz. Move the code to a new cpp file https://reviews.llvm.org/D25726 Files:

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-18 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Improve the libstdc++ smart pointer formatters - Display the strong/weak count in the summary - Display the pointed object as a synthetic member - Create

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-13 Thread Tamas Berghammer via lldb-commits
In case of Linux and Android we are using the qRegisterInfo packet and lldb-server fills it in based on the register definitions inside LLDB so for those targets it would be important to have all of the alias registers available. I don't have an AArch64-BE target at hand but I am pretty sure you

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Tamas Berghammer via lldb-commits
Hi Jason, Thank you for adding unit test for this code. I think the current implementation doesn't fail terribly on 16 vs 32 byte stack alignment because we use the "opc" from the instruction to calculate the write back address (to adjust the SP) so having the wrong size of the register won't

Re: [Lldb-commits] [lldb] r283351 - Try to fix Android build.

2016-10-05 Thread Tamas Berghammer via lldb-commits
It is using "gcc version 4.9 20150123 (prerelease) (GCC)" On Wed, Oct 5, 2016 at 11:12 AM Zachary Turner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > I don't know for sure, but I'm guessing it's using GCC, and perhaps even > an old one at that. > > On Wed, Oct 5, 2016 at 11:10 AM

[Lldb-commits] [lldb] r283262 - Fix the decorator of TestBreakpointCaseSensitivity

2016-10-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Oct 4 16:32:46 2016 New Revision: 283262 URL: http://llvm.org/viewvc/llvm-project?rev=283262=rev Log: Fix the decorator of TestBreakpointCaseSensitivity Modified:

[Lldb-commits] [lldb] r283237 - Fix FixupEnvironment on Android after the Args refactor

2016-10-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Oct 4 13:35:39 2016 New Revision: 283237 URL: http://llvm.org/viewvc/llvm-project?rev=283237=rev Log: Fix FixupEnvironment on Android after the Args refactor Modified: lldb/trunk/source/Host/linux/ProcessLauncherLinux.cpp Modified:

[Lldb-commits] [lldb] r281601 - Fix TestSymbolContextTwoFiles on Android after rL281595

2016-09-15 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Sep 15 05:49:55 2016 New Revision: 281601 URL: http://llvm.org/viewvc/llvm-project?rev=281601=rev Log: Fix TestSymbolContextTwoFiles on Android after rL281595 Modified:

Re: [Lldb-commits] [PATCH] D24514: Add support for DW_AT_ranges_base attribute

2016-09-15 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281595: Add support for DW_AT_ranges_base attribute (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D24514?vs=71316=71484#toc Repository: rL LLVM

[Lldb-commits] [lldb] r281595 - Add support for DW_AT_ranges_base attribute

2016-09-15 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Sep 15 03:53:33 2016 New Revision: 281595 URL: http://llvm.org/viewvc/llvm-project?rev=281595=rev Log: Add support for DW_AT_ranges_base attribute It is a new attribute emitted by clang as a GNU extension and will be part of Dwarf5. The purpose of the attribute is

[Lldb-commits] [lldb] r281594 - Try to fix windows build after rL281569

2016-09-15 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Sep 15 03:47:59 2016 New Revision: 281594 URL: http://llvm.org/viewvc/llvm-project?rev=281594=rev Log: Try to fix windows build after rL281569 Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h

Re: [Lldb-commits] [PATCH] D24514: Add support for DW_AT_ranges_base attribute

2016-09-14 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 71316. tberghammer added a comment. Adding a new test case https://reviews.llvm.org/D24514 Files: packages/Python/lldbsuite/test/python_api/symbol-context/two-files/TestSymbolContextTwoFiles.py

[Lldb-commits] [PATCH] D24514: Add support for DW_AT_ranges_base attribute

2016-09-13 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Add support for DW_AT_ranges_base attribute It is a new attribute emitted by clang as a GNU extension and will be part of Dwarf5. The purpose of the attribute is to

[Lldb-commits] [lldb] r281309 - Fix linux build after rL281273

2016-09-13 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Sep 13 04:27:21 2016 New Revision: 281309 URL: http://llvm.org/viewvc/llvm-project?rev=281309=rev Log: Fix linux build after rL281273 Modified: lldb/trunk/source/Core/StructuredData.cpp Modified: lldb/trunk/source/Core/StructuredData.cpp URL:

[Lldb-commits] [lldb] r280492 - Fix build breakage caused by r280490

2016-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Sep 2 10:56:33 2016 New Revision: 280492 URL: http://llvm.org/viewvc/llvm-project?rev=280492=rev Log: Fix build breakage caused by r280490 Modified: lldb/trunk/source/Symbol/OCamlASTContext.cpp Modified: lldb/trunk/source/Symbol/OCamlASTContext.cpp URL:

Re: [Lldb-commits] [PATCH] D24079: Always rely on CFI unwind info for linux vdso

2016-08-31 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14 @@ +12,4 @@ + +// Project includes +#include "AuxVector.h" +

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

2016-08-30 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280102: Remove mention of autoconf from the build instructions (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D24025?vs=69668=69701#toc Repository: rL LLVM

[Lldb-commits] [lldb] r280102 - Remove mention of autoconf from the build instructions

2016-08-30 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Aug 30 10:32:52 2016 New Revision: 280102 URL: http://llvm.org/viewvc/llvm-project?rev=280102=rev Log: Remove mention of autoconf from the build instructions autoconf+make have been removed from LLVM and LLDB ~6month ago. We shouldn't advertise it on the website as

[Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

2016-08-30 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: jingham, zturner. tberghammer added a subscriber: lldb-commits. Remove mention of autoconf from the build instructions autoconf+make have been removed from LLVM and LLDB ~6month ago. We shouldn't advertise it on the website as a

[Lldb-commits] [lldb] r278510 - Skip 2 android test what is broken because of debuggerd

2016-08-12 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Aug 12 09:17:05 2016 New Revision: 278510 URL: http://llvm.org/viewvc/llvm-project?rev=278510=rev Log: Skip 2 android test what is broken because of debuggerd debuggerd is a crash reporting system on android what installs some signal handler for SEGV to print a

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-08-02 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277443: Support for OCaml native debugging (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D22132?vs=64473=66456#toc Repository: rL LLVM https://reviews.llvm.org/D22132

[Lldb-commits] [lldb] r277443 - Support for OCaml native debugging

2016-08-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Aug 2 06:15:55 2016 New Revision: 277443 URL: http://llvm.org/viewvc/llvm-project?rev=277443=rev Log: Support for OCaml native debugging This introduces basic support for debugging OCaml binaries. Use of the native compiler with DWARF emission support (see

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-08-01 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. Do you want me to commit it in for you? https://reviews.llvm.org/D22132 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-01 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Pavel is OOO this week but the change looks good. One request: Can you move the following part out of the android specific part as well? ifdef PIE LDFLAGS += -pie endif It will make no difference at the moment but will make the code more generic and

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

2016-08-01 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as the 2 copy will diverge over time and cause extra maintenance cost. What do you think about trying to change LLVM to install this file instead

Re: [Lldb-commits] [PATCH] D22219: Support loading files even when incorrect file name specified by the linker

2016-07-22 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276411: Support loading files even when incorrect file name specified by the linker (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D22219?vs=63664=65064#toc Repository:

[Lldb-commits] [lldb] r276411 - Support loading files even when incorrect file name specified by the linker

2016-07-22 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Jul 22 07:55:35 2016 New Revision: 276411 URL: http://llvm.org/viewvc/llvm-project?rev=276411=rev Log: Support loading files even when incorrect file name specified by the linker "Incorrect" file name seen on Android whene the main executable is called

[Lldb-commits] [lldb] r276403 - Fix a crash when an ELF section symbol have no name

2016-07-22 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Jul 22 05:43:03 2016 New Revision: 276403 URL: http://llvm.org/viewvc/llvm-project?rev=276403=rev Log: Fix a crash when an ELF section symbol have no name Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified:

Re: [Lldb-commits] [PATCH] D22457: Unify process launching code on linux

2016-07-21 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with 2 minor comments Comment at: source/Host/linux/ProcessLauncherLinux.cpp:28-29 @@ +27,4 @@ + +// If there is no PATH variable specified inside the

Re: [Lldb-commits] [PATCH] D22219: Support loading files even when incorrect file name specified by the linker

2016-07-12 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 63664. tberghammer added a comment. Add SBMemoryRegionInfo::GetName http://reviews.llvm.org/D22219 Files: docs/lldb-gdb-remote.txt include/lldb/API/SBMemoryRegionInfo.h include/lldb/Target/MemoryRegionInfo.h

[Lldb-commits] [PATCH] D22219: Support loading files even when incorrect file name specified by the linker

2016-07-11 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Support loading files even when incorrect file name specified by the linker "Incorrect" file name seen on Android

Re: [Lldb-commits] [PATCH] D22211: Change the /proc//maps to not assert on incorrect input

2016-07-11 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275060: Change the /proc//maps to not assert on incorrect input (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D22211?vs=63485=63503#toc Repository: rL LLVM

[Lldb-commits] [lldb] r275060 - Change the /proc//maps to not assert on incorrect input

2016-07-11 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 11 08:43:27 2016 New Revision: 275060 URL: http://llvm.org/viewvc/llvm-project?rev=275060=rev Log: Change the /proc//maps to not assert on incorrect input If LLDB reads some incorrect input form /proc//maps then it should report an error instead of assert-ing as

[Lldb-commits] [PATCH] D22211: Change the /proc//maps to not assert on incorrect input

2016-07-11 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: labath. tberghammer added a subscriber: lldb-commits. Change the /proc//maps to not assert on incorrect input If LLDB reads some incorrect input form /proc//maps then it should report an error instead of assert-ing as we don't want

Re: [Lldb-commits] [lldb] r274725 - debugserver will now report the minimum version load command

2016-07-07 Thread Tamas Berghammer via lldb-commits
Hi Jason, This CL caused a build failure on our OSX build bot: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/11405/steps/ninja%20build%20local/logs/stdio I committed in a possible fix at http://reviews.llvm.org/rL274743 but please take a look as I don't know too much about

[Lldb-commits] [lldb] r274743 - Try to fix the OSX build with old SDK after r274725

2016-07-07 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Jul 7 05:38:05 2016 New Revision: 274743 URL: http://llvm.org/viewvc/llvm-project?rev=274743=rev Log: Try to fix the OSX build with old SDK after r274725 Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified:

Re: [Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274635: Add oat symbolization support for odex files (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D22040?vs=62851=62895#toc Repository: rL LLVM

[Lldb-commits] [lldb] r274635 - Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Jul 6 11:40:09 2016 New Revision: 274635 URL: http://llvm.org/viewvc/llvm-project?rev=274635=rev Log: Add oat symbolization support for odex files Differential revision: http://reviews.llvm.org/D22040 Modified:

[Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Add oat symbolization support for odex files http://reviews.llvm.org/D22040 Files:

Re: [Lldb-commits] [PATCH] D22029: Fix ADB client disconnect issues

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D22029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22039: [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good. You might want to print the errno a bit better but I am fine with the current implementation as well. http://reviews.llvm.org/D22039

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274617: Add data formatter for libstdc++ shared_ptr and weak_ptr (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D21984?vs=62730=62838#toc Repository: rL LLVM

[Lldb-commits] [lldb] r274617 - Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Jul 6 04:50:00 2016 New Revision: 274617 URL: http://llvm.org/viewvc/llvm-project?rev=274617=rev Log: Add data formatter for libstdc++ shared_ptr and weak_ptr Differential revision: http://reviews.llvm.org/D21984 Added:

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-05 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 62730. tberghammer added a comment. Apply clang-format http://reviews.llvm.org/D21984 Files: include/lldb/DataFormatters/VectorIterator.h packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile

[Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-05 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Add data formatter for libstdc++ shared_ptr and weak_ptr http://reviews.llvm.org/D21984 Files:

[Lldb-commits] [lldb] r274500 - Ignore oatdata and oatexec symbols more widely

2016-07-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 4 08:31:57 2016 New Revision: 274500 URL: http://llvm.org/viewvc/llvm-project?rev=274500=rev Log: Ignore oatdata and oatexec symbols more widely These are artifical symbols inside android oat files without any value for the user while causing a significant

Re: [Lldb-commits] [PATCH] D21680: Fix the libc++ pretty printers for the android NDK

2016-07-04 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274489: Fix the libc++ pretty printers for the android NDK (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D21680?vs=61770=62655#toc Repository: rL LLVM

[Lldb-commits] [lldb] r274489 - Fix the libc++ pretty printers for the android NDK

2016-07-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 4 04:13:10 2016 New Revision: 274489 URL: http://llvm.org/viewvc/llvm-project?rev=274489=rev Log: Fix the libc++ pretty printers for the android NDK The libc++ shipped with the android NDK is shipped using a different internal namespace then the upstream libc++

[Lldb-commits] [lldb] r274488 - Fix ClangASTContext after some clang API changes

2016-07-04 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jul 4 04:11:08 2016 New Revision: 274488 URL: http://llvm.org/viewvc/llvm-project?rev=274488=rev Log: Fix ClangASTContext after some clang API changes Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D21680: Fix the libc++ pretty printers for the android NDK

2016-06-24 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: clayborg, granata.enrico, ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Fix the libc++ pretty printers for the android NDK The libc++ shipped with the android NDK is shipped

Re: [Lldb-commits] [PATCH] Updated documentation for SBAddress

2016-06-17 Thread Tamas Berghammer via lldb-commits
Can you upload the patch to http://reviews.llvm.org/differential/ (we do all of the code review there)? On Fri, Jun 10, 2016 at 6:08 PM John Lindal via lldb-commits < lldb-commits@lists.llvm.org> wrote: > I never heard back on this. Should I file a ticket? > > Thanks, > John > > On Thu, Apr 7,

Re: [Lldb-commits] [PATCH] D21324: Remove Platform usages from NativeProcessLinux

2016-06-14 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D21324 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r271618 - Fix makefile for TestExternCSymbols

2016-06-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Jun 2 20:03:04 2016 New Revision: 271618 URL: http://llvm.org/viewvc/llvm-project?rev=271618=rev Log: Fix makefile for TestExternCSymbols Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/extern_c/Makefile Modified:

Re: [Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

2016-06-01 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271453: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject. (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D20875?vs=59265=59321#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

2016-06-01 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good, thanks for fixing it (I seen strange issues caused by this so it will help a lot). http://reviews.llvm.org/D20875 ___

  1   2   3   4   5   6   >