This revision was automatically updated to reflect the committed changes.
Closed by commit rL314849: cmake + xcode: prevent gtests from using includes
from project root (authored by penryu).
Changed prior to commit:
https://reviews.llvm.org/D36598?vs=112052=117587#toc
Repository:
rL LLVM
penryu updated this revision to Diff 112052.
penryu added a comment.
This patch limits the above include dir to unittests/, and renamed some headers
to reduce ambiguity about their purpose, as suggested by beanz.
https://reviews.llvm.org/D36598
Files:
lldb.xcodeproj/project.pbxproj
penryu added a comment.
Note that these changes were tested on Darwin with both cmake and xcode.
https://reviews.llvm.org/D36598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
penryu created this revision.
Herald added subscribers: mgorny, emaste.
At present, several gtests in the lldb open source codebase are using
#include statements rooted at $(SOURCE_ROOT)/${LLDB_PROJECT_ROOT}.
This patch cleans up this directory/include structure for both CMake and
Xcode build
penryu added a comment.
Committed revision 310499.
Closing revision https://reviews.llvm.org/D36496 'Fix VASprintfTest.cpp for
Darwin, add checks'...
https://reviews.llvm.org/D36496
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
penryu added a comment.
I'd prototyped this as simply prepending "DISABLED_" for non-Windows, but as
this was designed as a temporary measure, I decided to ensure the same behavior
was tested on Windows, and similar/equivalent behavior tested on other
platforms.
penryu created this revision.
The EncodingError test ensures that trying to encode a multibyte wchar
with a given codepage fails. If setlocale() fails, the encoding is
performed using the current locale, which may or may not fail.
This patch asserts that both setlocale() operations are
penryu added a comment.
Committing 'https://reviews.llvm.org/D36485: Add existing unit tests to Xcode
project'...
Sendinglldb.xcodeproj/project.pbxproj
Transmitting file data .done
Committing transaction...
Committed revision 310417.
Closing revision https://reviews.llvm.org/D36485 'Add
penryu edited reviewers, added: spyffe, jingham; removed: zturner, labath.
penryu added a comment.
This is really an Xcode-only change.
https://reviews.llvm.org/D36485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
penryu created this revision.
This adds gtest test files to the Xcode project which were
previously only in the cmake config. This is the first of several
planned merges.
https://reviews.llvm.org/D36485
Files:
lldb.xcodeproj/project.pbxproj
Index: lldb.xcodeproj/project.pbxproj
penryu added a comment.
Note that VASprintfTest.cpp is added to the xcodeproj but not added to the
lldb-gtest-build target _YET_. It needs some work before I can enable it.
https://reviews.llvm.org/D36485
___
lldb-commits mailing list
penryu requested review of this revision.
penryu added a comment.
This revision is now accepted and ready to land.
I need to learn more about the number formatters before I make more significant
changes than those below. As written currently, it leaves the logic intact and
resolves the warning.
penryu added a comment.
Thanks, sas.
I'll be honest, my prefer solution involves an inlined function (uint64_t ->
TypeCodes) that eliminates the cast from the NSNumberSummaryProvider() method
altogether. This way we can handle any dirty mappings from raw memory directory
to the enum within
penryu created this revision.
Testing the value of type_code against the closed enum TypeCodes
provides statically verifiable completeness of testing. However, one
branch assigns to type_code by casting directly from a masked integer
value. This is currently handled by adding a default: case
14 matches
Mail list logo
