stigger added inline comments.
Comment at: include/lldb/Host/FileSpec.h:712
@@ +711,3 @@
+ PathSyntax syntax = ePathSyntaxHostNative,
+ llvm::Triple *triple = nullptr);
+
labath wrote:
> I don't think the default-null parameter here is a
stigger added a comment.
In https://reviews.llvm.org/D20041#533725, @zturner wrote:
> How difficult would be it be to eliminate the `PathSyntax` enumeration
> entirely and update every user of `PathSyntax` to use a triple instead?
I've attempted to do it and hit two issues which I'm not sure
stigger added a comment.
Ping.
https://reviews.llvm.org/D20041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
stigger added a comment.
These are valid points, but they apply to Linux and Windows as well: nothing
prevents you from mounting a case-insensitive FS on Linux or a case-sensitive
network share on Windows. However, in most cases the file system is going to be
case-sensitive on Linux and
stigger created this revision.
stigger added a reviewer: zturner.
stigger added a subscriber: lldb-commits.
- File path comparisons should be case-insensitive on OS X
- Fixed TestBreakpointCaseSensitivity
http://reviews.llvm.org/D20041
Files:
include/lldb/Host/FileSpec.h
