https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1390,7 +1414,10 @@ llvm::json::Value CreateVariable(lldb::SBValue v,
int64_t var_ref,
object.try_emplace("variablesReference", 0);
if (v.GetDeclaration().IsValid())
-object.try_emplace("declarationLocationReference", var_ref);
+object.try_emplace("declaratio
@@ -4087,32 +4114,64 @@ void request_variables(const llvm::json::Object
&request) {
void request_locations(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
- auto arguments = request.getObject("arguments");
+ auto *argume
@@ -1611,16 +1624,17 @@ void request_evaluate(const llvm::json::Object
&request) {
VariableDescription desc(value);
EmplaceSafeString(body, "result", desc.GetResult(context));
EmplaceSafeString(body, "type", desc.display_type_name);
- if (value.MightHave
@@ -78,7 +78,7 @@ bool CommandObjectThreadTraceStartIntelPT::DoExecuteOnThreads(
llvm::ArrayRef tids) {
if (Error err = m_trace.Start(tids, m_options.m_ipt_trace_size,
m_options.m_enable_tsc,
m_options.m_psb_period))
-result.SetError(S
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/108719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context == "repl") {
+ // If the expression is empty and the last e
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context != "hover") {
walter-erquinigo wrote:
yeah, th
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -191,6 +198,14 @@ def run_test_evaluate_expressions(
self.continue_to_next_stop()
self.assertEvaluate("my_bool_vec", "size=2")
+# Test memory read, especially with 'empty' repeat commands.
+if context == "repl":
+ self.continue_to_ne
https://github.com/walter-erquinigo approved this pull request.
+1
https://github.com/llvm/llvm-project/pull/108226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/108036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
Thanks for working on this.
Could you please write some tests?
https://github.com/llvm/llvm-project/pull/108036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -60,7 +60,10 @@ def run_test_evaluate_expressions(
# Expressions at breakpoint 1, which is in main
self.assertEvaluate("var1", "20")
+# Empty expression should equate to the previous expression.
walter-erquinigo wrote:
Please add a
https://github.com/walter-erquinigo requested changes to this pull request.
Thanks for working on this!
I second all that Pavel said.
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1370,13 +1395,16 @@ CreateRunInTerminalReverseRequest(const
llvm::json::Object &launch_request,
if (!cwd.empty())
run_in_terminal_args.try_emplace("cwd", cwd);
- // We need to convert the input list of environments variables into a
- // dictionary
- std::vector e
@@ -3801,6 +3801,17 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
+auto process = g_dap.target.GetProcess();
+auto sel
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/106907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106799
This FORM already has support within LLDB to be parsed as a 16-byte
BLOCK, and all that is left to properly support it in the DWARFParser is
to add it to some enums.
With this, I can debug programs that
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/106765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Revert commit: https://github.com/llvm/llvm-project/pull/106765
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106765
Reverts llvm/llvm-project#106609
>From c6ff3f00afa70a47853af3e420aa8a99f76db3a9 Mon Sep 17 00:00:00 2001
From: Walter Erquinigo
Date: Fri, 30 Aug 2024 13:17:47 -0400
Subject: [PATCH] =?UTF-8?q?Revert=2
walter-erquinigo wrote:
@clayborg , sure!
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Merging because of time constraints, but happy to get follow up feedback.
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106609
My build of LLDB is all the time loading targets with a version of libc++ that
was built with gcc that uses the DW_FORM 0x1e that is not implemented by LLVM,
and I doubt it'll ever implement it. It's u
@@ -996,4 +996,33 @@ void DAP::SetThreadFormat(llvm::StringRef format) {
}
}
+InstructionBreakpoint *
+DAP::GetInstructionBreakpoint(const lldb::break_id_t bp_id) {
+
walter-erquinigo wrote:
The empty line :) Just to keep consistency with the rest of the co
https://github.com/walter-erquinigo approved this pull request.
This LGTM, and thank you for your diligence with writing tests.
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
@@ -996,4 +996,33 @@ void DAP::SetThreadFormat(llvm::StringRef format) {
}
}
+InstructionBreakpoint *
+DAP::GetInstructionBreakpoint(const lldb::break_id_t bp_id) {
+
walter-erquinigo wrote:
remove this line
https://github.com/llvm/llvm-project/pull/105278
@@ -893,7 +957,13 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
body.try_emplace("reason", "exception");
EmplaceSafeString(body, "description", exc_bp->label);
} else {
- body.try_emplace("reason", "breakpoint");
+ InstructionBreakp
@@ -4082,6 +4084,254 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "SetInstructionBreakpointsRequest" : {
+// "allOf" : [
+// {"$ref" : "#/definitions/Request"}, {
+//
@@ -0,0 +1,36 @@
+//===-- InstructionBreakpoint.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
https://github.com/walter-erquinigo approved this pull request.
This LGTM. I'd just want a rename from `instructionReference` to
`addressReference` or `instructionAddressReference` for clarity.
https://github.com/llvm/llvm-project/pull/105278
___
lldb
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thanks for the screenshot, man!
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -58,6 +64,21 @@ export class LLDBDapExtension extends DisposableContext {
new LLDBDapDescriptorFactory(this.lldbDapOptions),
),
);
+
+this.pushSubscription(
+ vscode.workspace.onDidChangeConfiguration((event) => {
+if (event.affectsConfigur
@@ -14,10 +14,49 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,49 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4078,6 +4255,9 @@ void RegisterRequestCallbacks() {
g_dap.RegisterRequestCallback("threads", request_threads);
g_dap.RegisterRequestCallback("variables", request_variables);
g_dap.RegisterRequestCallback("disassemble", request_disassemble);
+ // Instruction breapoint
walter-erquinigo wrote:
> Cool, I'll try them when I've got some spare time.
I'd very much appreciate it. I sometimes have time, but I don't even have
access to a proper Windows machine to make that work :(
https://github.com/llvm/llvm-project/pull/105604
__
walter-erquinigo wrote:
@DavidSpickett I think this has been mostly an issue with the fact that no one
has tried long enough to make lldb-dap work nicely on windows. But I'm sure
most tests should just pass without too much effort.
https://github.com/llvm/llvm-project/pull/105604
_
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
walter-erquinigo wrote:
If @clayborg takes too long to review, I'd suggest merging this and then acting
on any late feedback. But give him a few days for sure if possible. He's a
better reviewer than me.
https://github.com/llvm/llvm-project/pull/102928
_
https://github.com/walter-erquinigo approved this pull request.
This LGTM considering that the screenshot looks right and this passes all the
tests.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm
walter-erquinigo wrote:
> > @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> > extension. Once this change gets it, I'll update the Mojo extension to use
> > the new declaration info and remove $__lldb_extensions.declaration.
>
> Is that extension's source code availabl
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
https://github.com/walter-erquinigo approved this pull request.
I'm approving this to unblock.
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/walter-erquinigo approved this pull request.
cool
Don't forget to run `npm run format` before landing this
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,6 @@
+CXX_SOURCES := main-copy.cpp
+CXXFLAGS_EXTRAS := -O1 -g
walter-erquinigo wrote:
why don't you use -O0?
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/walter-erquinigo commented:
This LGTM, but I'd like @clayborg to give a second look.
Thanks for this fancy feature, I've been wanting it for a while
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-
@@ -4046,6 +4048,181 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// SetInstructionBreakpoints request; value of command field is
+// 'setInstructionBreakpoints'. Replaces all exist
@@ -0,0 +1,81 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
https://github.com/walter-erquinigo commented:
Overall looks very nice, and I want to make sure that this works for the Mojo
language after this gets merged.
Please rebase this change so that I have a better time reviewing it.
Also, happy to chime in on discourse to make sure that the RFC gets a
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
This looks good to me, but I'd like @clayborg to have a second look.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
walter-erquinigo wrote:
@vogelsgesang , can you show a screenshot of the variables pane after this
change? I want to make sure that simple types, like ints, are not displayed as
having children.
https://github.com/llvm/llvm-project/pull/102928
___
ll
walter-erquinigo wrote:
@vogelsgesang , the `$__lldb_extensions.declaration` is used by the Mojo
extension. Once this change gets it, I'll update the Mojo extension to use the
new declaration info and remove `$__lldb_extensions.declaration`.
https://github.com/llvm/llvm-project/pull/102928
___
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
@@ -399,7 +399,7 @@ void SendProcessEvent(LaunchMethod launch_method) {
// Grab any STDOUT and STDERR from the process and send it up to VS Code
// via an "output" event to the "stdout" and "stderr" categories.
void SendStdOutStdErr(lldb::SBProcess &process) {
- char buffer[10
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
Just a minor nit and good to go
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -311,10 +309,22 @@ void DAP::SendOutput(OutputType o, const llvm::StringRef
output) {
category = "telemetry";
break;
}
- body.try_emplace("category", category);
- EmplaceSafeString(body, "output", output.str());
- event.try_emplace("body", std::move(body));
-
https://github.com/walter-erquinigo approved this pull request.
fancy
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thank you very much for implementing this. I've been wanting this for long.
https://github.com/llvm/llvm-project/pull/105464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
@@ -701,6 +701,8 @@ void request_attach(const llvm::json::Object &request) {
GetBoolean(arguments, "enableAutoVariableSummaries", false);
g_dap.enable_synthetic_child_debugging =
GetBoolean(arguments, "enableSyntheticChildDebugging", false);
+ g_dap.enable_displa
https://github.com/walter-erquinigo requested changes to this pull request.
@jeffreytan81 , could you make the default to be true if the current platform
is Mac? The extension should just work nicely for the 99% of people who don't
use massive binaries.
https://github.com/llvm/llvm-project/pul
walter-erquinigo wrote:
@ashgti , do you have any opinions on this?
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@Da-Viper , a better way to do this is that, instead of checking for the path
upon initialization, you add this checking logic in the
`createDebugAdapterDescriptor` function, which only gets triggered when you
launch the debugger. This will be less annoying to users who
@@ -23,31 +22,41 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
return packageJSONExecutable;
}
- try {
-const fileStats = await fs.stat(path);
-if (!fileStats.isFile() && !fileStats.isSymbolicLink()) {
- throw new Error
@@ -192,8 +192,6 @@ struct DAP {
std::mutex call_mutex;
std::map
inflight_reverse_requests;
- StartDebuggingRequestHandler start_debugging_request_handler;
- ReplModeRequestHandler repl_mode_request_handler;
walter-erquinigo wrote:
btw, do you use
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/104824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -1,4 +1,5 @@
import * as vscode from "vscode";
+import * as fs from "node:fs/promises";
walter-erquinigo wrote:
don't use this
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-com
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
could you share a screenshot or something like that? :)
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
This seems pretty cool!
Question: what would happen if the top frame (the one with the PC) gets
filtered out by the recognizer?
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/104398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/104398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 850 matches
Mail list logo
