Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-19 Thread Oleksiy Vyalov via lldb-commits 
ovyalov added a comment.

LGTM


Repository:
  rL LLVM

http://reviews.llvm.org/D12100



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-18 Thread Oleksiy Vyalov via lldb-commits 
ovyalov accepted this revision.


Comment at: include/lldb/Core/RegisterValue.h:51
@@ -51,2 +50,3 @@
 {
+m_scalar = (unsigned long)0;
 }

Nit: you can initialize m_scalar within initializer list.


Comment at: include/lldb/Core/RegisterValue.h:185
@@ -190,1 +184,3 @@
+llvm::APInt
+GetAsUInt128 (llvm::APInt fail_value, bool *success_ptr = NULL) const;
 

Could you pass fail_value as a const reference?


Repository:
  rL LLVM

http://reviews.llvm.org/D12100



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-18 Thread Greg Clayton via lldb-commits 
clayborg added a comment.

Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D12100



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits