This revision was automatically updated to reflect the committed changes.
Closed by commit rL294210: Get rid of Error::PutToLog(). (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D29514?vs=87036=87260#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29514
Files:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good, just make sure it compiles.
Comment at: lldb/include/lldb/Core/Log.h:18
#include "lldb/Utility/ConstString.h"
+#include "lldb/Utility/Error.h"
#include
zturner updated this revision to Diff 87036.
https://reviews.llvm.org/D29514
Files:
lldb/include/lldb/Core/Log.h
lldb/include/lldb/Utility/Error.h
lldb/source/Core/Communication.cpp
lldb/source/Host/common/Host.cpp
lldb/source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
zturner added a comment.
Fair enough, I can do that.
https://reviews.llvm.org/D29514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In https://reviews.llvm.org/D29514#666285, @labath wrote:
> I'm not opposed to this patch, if people really want it, but I don't really
> see the value of this macro.
> Why couldn't I write
> `LLDB_LOG(log, "foo: {0}", error);`
> instead of
> `LLDB_LOG_ERROR(log,
clayborg added a comment.
So I agree with Pavel. Let us know what you think
https://reviews.llvm.org/D29514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
I realize the functionality would add a "error: " prefix if it wasn't there,
but it seems like we could add this as a formatting option of the
lldb_private::Error class? Then we can just switch the logging code to put the
error in as a log item and add the extra flag
labath added a comment.
As for the modules part, I assumed the Log class will end up in the lowest
layer also. I intended to move it there after I am done with it, but we can do
it sooner if that is stopping you from doing anything. ( I do agree that it
makes sense to reverse the dependency
labath added a comment.
I'm not opposed to this patch, if people really want it, but I don't really see
the value of this macro.
Why couldn't I write
`LLDB_LOG(log, "foo: {0}", error);`
instead of
`LLDB_LOG_ERROR(log, error, "foo");`
Am I missing something?
https://reviews.llvm.org/D29514
zturner created this revision.
Instead of having the Error class (which is in Utility) know about logging
(which is in Core), it seems more appropriate to put all logging code together,
and teach Log about errors rather than teaching Error about logs. This patch
does so.
10 matches
Mail list logo