[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4778f40f782f: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

amccarth added a comment. On Windows, it _does_ rewrite `argv[0]`, but it looks like it tries to not change whether it was relative/absolute, so I think this is fine. Thanks for the clean-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

mstorsjo added a comment. In D68770#1704663 , @amccarth wrote: > Cool. I didn't know about InitLLVM. That makes things much cleaner. > > Though I do recall recently seeing another complaint about `argv[0]` not > being preserved as typed but being

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Cool. I didn't know about InitLLVM. That makes things much cleaner. Though I do recall recently seeing another complaint about `argv[0]` not being preserved as typed but being replaced

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk. Herald added a project: LLDB. This avoids the currently MSVC specific codepath of using the wchar entry point and converting that to utf8. In the main lldb driver, we had this MSVC specific codepath, but in other