subject:"\[Lldb\-commits\] \[PATCH\] D79147\: Switch to using \-debug\-info\-kind=constructor as default \(from =limited\)"

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-29 Thread David Blaikie via Phabricator via lldb-commits

dblaikie added a subscriber: echristo.
dblaikie added a comment.

In D79147#2178104 , @russell.gallop 
wrote:

> Hi,
>
> It looks like is causing one of the debuginfo-tests: 
> llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't 
> think the debuginfo-tests are run on any bot (but probably should be!). I 
> bisected the failure back to this change.
>
> Please could you take a look?
>
> Thanks
> Russ
>
>   FAIL: debuginfo-tests :: llgdb-tests/nrvo-string.cpp (1 of 1)
>    TEST 'debuginfo-tests :: llgdb-tests/nrvo-string.cpp' 
> FAILED 
>   Script:
>   --
>   : 'RUN: at line 4';   /home//git/llvm-project/stage1/bin/clang 
> --driver-mode=g++ -O0 -fno-exceptions --target=x86_64-unknown-linux-gnu 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
>  -g
>   : 'RUN: at line 5';   
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/test_debuginfo.pl 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
>   : 'RUN: at line 6';   /home//git/llvm-project/stage1/bin/clang 
> --driver-mode=g++ -O1 -fno-exceptions --target=x86_64-unknown-linux-gnu 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
>  -g
>   : 'RUN: at line 7';   
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/test_debuginfo.pl 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
>   --
>   Exit Code: 1
>   
>   Command Output (stdout):
>   --
>   Debugger output was:
>   Breakpoint 1 at 0x4004f8: file 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, 
> line 23.
>   Breakpoint 2 at 0x400563: file 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, 
> line 39.
>   
>   Breakpoint 1, get_string () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:23
>   23stop();
>   $1 = 3
>   
>   Breakpoint 2, get_string2 () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
>   39stop();
>   
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.debugger.script:6:
>  Error in sourced command file:
>   There is no member named i.
>   
>   --
>   Command Output (stderr):
>   --
>   
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:52:11:
>  error: CHECK: expected string not found in input
>   // CHECK: = 5
> ^
>   
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output:8:1:
>  note: scanning from here
>   Breakpoint 2, get_string2 () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
>   ^
>   
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output:8:10:
>  note: possible intended match here
>   Breakpoint 2, get_string2 () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
>^
>   
>   Input file: 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output
>   Check file: 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp
>   
>   -dump-input=help explains the following input dump.
>   
>   Full input was:
>   <<
>   1: Breakpoint 1 at 0x4004f8: file 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, 
> line 23.
>   2: Breakpoint 2 at 0x400563: file 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, 
> line 39.
>   3:
>   4: Breakpoint 1, get_string () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:23
>   5: 23 stop();
>   6: $1 = 3
>   7:
>   8: Breakpoint 2, get_string2 () at 
> /home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
>   check:52'0 
> X
>  error: no match found
>   check:52'1  ?   
>  possible intended match
>   9: 39 stop();
>   check:52'0 ~~
>  10: 
> /home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.debugger.script:6:
>  Error in sourced command file:
>   check:52'0 
>

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-28 Thread Russell Gallop via Phabricator via lldb-commits

russell.gallop added a comment.

Hi,

It looks like is causing one of the debuginfo-tests: 
llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't 
think the debuginfo-tests are run on any bot (but probably should be!). I 
bisected the failure back to this change.

Please could you take a look?

Thanks
Russ

  FAIL: debuginfo-tests :: llgdb-tests/nrvo-string.cpp (1 of 1)
   TEST 'debuginfo-tests :: llgdb-tests/nrvo-string.cpp' 
FAILED 
  Script:
  --
  : 'RUN: at line 4';   /home//git/llvm-project/stage1/bin/clang 
--driver-mode=g++ -O0 -fno-exceptions --target=x86_64-unknown-linux-gnu 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
 -g
  : 'RUN: at line 5';   
/home//git/llvm-project/debuginfo-tests/llgdb-tests/test_debuginfo.pl 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
  : 'RUN: at line 6';   /home//git/llvm-project/stage1/bin/clang 
--driver-mode=g++ -O1 -fno-exceptions --target=x86_64-unknown-linux-gnu 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp -o 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
 -g
  : 'RUN: at line 7';   
/home//git/llvm-project/debuginfo-tests/llgdb-tests/test_debuginfo.pl 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.tmp.out
  --
  Exit Code: 1
  
  Command Output (stdout):
  --
  Debugger output was:
  Breakpoint 1 at 0x4004f8: file 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, line 
23.
  Breakpoint 2 at 0x400563: file 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, line 
39.
  
  Breakpoint 1, get_string () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:23
  23stop();
  $1 = 3
  
  Breakpoint 2, get_string2 () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
  39stop();
  
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.debugger.script:6:
 Error in sourced command file:
  There is no member named i.
  
  --
  Command Output (stderr):
  --
  
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:52:11:
 error: CHECK: expected string not found in input
  // CHECK: = 5
^
  
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output:8:1:
 note: scanning from here
  Breakpoint 2, get_string2 () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
  ^
  
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output:8:10:
 note: possible intended match here
  Breakpoint 2, get_string2 () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
   ^
  
  Input file: 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.gdb.output
  Check file: 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp
  
  -dump-input=help explains the following input dump.
  
  Full input was:
  <<
  1: Breakpoint 1 at 0x4004f8: file 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, line 
23.
  2: Breakpoint 2 at 0x400563: file 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp, line 
39.
  3:
  4: Breakpoint 1, get_string () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:23
  5: 23 stop();
  6: $1 = 3
  7:
  8: Breakpoint 2, get_string2 () at 
/home//git/llvm-project/debuginfo-tests/llgdb-tests/nrvo-string.cpp:39
  check:52'0 
X
 error: no match found
  check:52'1  ? 
   possible intended match
  9: 39 stop();
  check:52'0 ~~
 10: 
/home//git/llvm-project/stage1/projects/debuginfo-tests/llgdb-tests/Output/nrvo-string.cpp.debugger.script:6:
 Error in sourced command file:
  check:52'0 
~~~
 11: There is no member named i.
  check:52'0 ~~~
  >>
  
  --


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79147/new/

https://reviews.llvm.org/D79147

___
lldb-commits

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-10 Thread Amy Huang via Phabricator via lldb-commits

akhuang updated this revision to Diff 276778.
akhuang added a comment.

fix one more test case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79147/new/

https://reviews.llvm.org/D79147

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/cl-options.c
  clang/test/Driver/clang-g-opts.c
  clang/test/Driver/cuda-dwarf-2.cu
  clang/test/Driver/debug-options-as.c
  clang/test/Driver/debug-options.c
  clang/test/Driver/integrated-as.s
  clang/test/Driver/myriad-toolchain.c
  clang/test/Driver/openmp-offload-gpu.c
  clang/test/Driver/split-debug.c
  lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp

Index: lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
===
--- lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
+++ lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
@@ -106,6 +106,7 @@
 int main() {
   MemberTest::Base B1;
   B1.Get();
+  MemberTest::Class C1;
   MemberTest::Class::StaticMemberFunc(1, 10, 2);
   return 0;
 }
Index: clang/test/Driver/split-debug.c
===
--- clang/test/Driver/split-debug.c
+++ clang/test/Driver/split-debug.c
@@ -68,18 +68,18 @@
 // RUN: FileCheck -check-prefix=CHECK-NOINLINE-WITHOUT-SPLIT < %t %s
 //
 // CHECK-NOINLINE-WITHOUT-SPLIT: "-fno-split-dwarf-inlining"
-// CHECK-NOINLINE-WITHOUT-SPLIT: "-debug-info-kind=limited"
+// CHECK-NOINLINE-WITHOUT-SPLIT: "-debug-info-kind=constructor"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gmlt -gsplit-dwarf -fno-split-dwarf-inlining -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-WITH-GMLT < %t %s
 //
-// CHECK-SPLIT-WITH-GMLT: "-debug-info-kind=limited"
+// CHECK-SPLIT-WITH-GMLT: "-debug-info-kind=constructor"
 // CHECK-SPLIT-WITH-GMLT: "-split-dwarf-output"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -fno-split-dwarf-inlining -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-WITH-NOINL < %t %s
 //
-// CHECK-SPLIT-WITH-NOINL: "-debug-info-kind=limited"
+// CHECK-SPLIT-WITH-NOINL: "-debug-info-kind=constructor"
 // CHECK-SPLIT-WITH-NOINL: "-split-dwarf-output"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -gmlt -fsplit-dwarf-inlining -S -### %s 2> %t
@@ -92,7 +92,7 @@
 // RUN: %clang -target x86_64-unknown-linux-gnu -gmlt -gsplit-dwarf -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-OVER-GMLT < %t %s
 //
-// CHECK-SPLIT-OVER-GMLT: "-debug-info-kind=limited"
+// CHECK-SPLIT-OVER-GMLT: "-debug-info-kind=constructor"
 // CHECK-SPLIT-OVER-GMLT: "-split-dwarf-file"
 // CHECK-SPLIT-OVER-GMLT: "-split-dwarf-output"
 
@@ -117,6 +117,6 @@
 // RUN: %clang -target x86_64-unknown-linux-gnu -g0 -gsplit-dwarf=split -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-OVER-G0 < %t %s
 //
-// CHECK-SPLIT-OVER-G0: "-debug-info-kind=limited"
+// CHECK-SPLIT-OVER-G0: "-debug-info-kind=constructor"
 // CHECK-SPLIT-OVER-G0: "-split-dwarf-file"
 // CHECK-SPLIT-OVER-G0: "-split-dwarf-output"
Index: clang/test/Driver/openmp-offload-gpu.c
===
--- clang/test/Driver/openmp-offload-gpu.c
+++ clang/test/Driver/openmp-offload-gpu.c
@@ -241,7 +241,7 @@
 
 // HAS_DEBUG-NOT: warning: debug
 // HAS_DEBUG: "-triple" "nvptx64-nvidia-cuda"
-// HAS_DEBUG-SAME: "-debug-info-kind={{limited|line-tables-only}}"
+// HAS_DEBUG-SAME: "-debug-info-kind={{constructor|line-tables-only}}"
 // HAS_DEBUG-SAME: "-dwarf-version=2"
 // HAS_DEBUG-SAME: "-fopenmp-is-device"
 // HAS_DEBUG: ptxas
Index: clang/test/Driver/myriad-toolchain.c
===
--- clang/test/Driver/myriad-toolchain.c
+++ clang/test/Driver/myriad-toolchain.c
@@ -83,7 +83,7 @@
 // NOSTDLIB-NOT: "-lc"
 
 // RUN: %clang -### -c -g %s -target sparc-myriad 2>&1 | FileCheck -check-prefix=G_SPARC %s
-// G_SPARC: "-debug-info-kind=limited" "-dwarf-version=2"
+// G_SPARC: "-debug-info-kind=constructor" "-dwarf-version=2"
 
 // RUN: %clang -### -c %s -target sparc-myriad-rtems -fuse-init-array 2>&1 \
 // RUN: | FileCheck -check-prefix=USE-INIT-ARRAY %s
Index: clang/test/Driver/integrated-as.s
===
--- clang/test/Driver/integrated-as.s
+++ clang/test/Driver/integrated-as.s
@@ -27,19 +27,19 @@
 // XA_INCLUDE2: "-Ifoo_dir"
 
 // RUN: %clang -### -target x86_64--- -c -integrated-as %s -gdwarf-4 -gdwarf-2 2>&1 | FileCheck --check-prefix=DWARF2 %s
-// DWARF2: "-debug-info-kind=limited" "-dwarf-version=2"
+// DWARF2: "-debug-info-kind=constructor" "-dwarf-version=2"
 
 // RUN: %clang -### -target x86_64--- -c -integrated-as %s -gdwarf-3 2>&1 | FileCheck --check-prefix=DWARF3 %s
-// DWARF3: "-debug-info-kind=limited" "-dwarf-version=3"
+// DWARF3: "-debug-info-kind=constructor" "-dwarf-version=3"
 
 // RUN: %clang -### -target x86_64--- -c

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-10 Thread Amy Huang via Phabricator via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor 
as default (from =limited) (authored by akhuang).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79147/new/

https://reviews.llvm.org/D79147

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/cl-options.c
  clang/test/Driver/clang-g-opts.c
  clang/test/Driver/cuda-dwarf-2.cu
  clang/test/Driver/debug-options-as.c
  clang/test/Driver/debug-options.c
  clang/test/Driver/integrated-as.s
  clang/test/Driver/myriad-toolchain.c
  clang/test/Driver/openmp-offload-gpu.c
  clang/test/Driver/split-debug.c
  lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp

Index: lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
===
--- lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
+++ lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
@@ -106,6 +106,7 @@
 int main() {
   MemberTest::Base B1;
   B1.Get();
+  MemberTest::Class C1;
   MemberTest::Class::StaticMemberFunc(1, 10, 2);
   return 0;
 }
Index: clang/test/Driver/split-debug.c
===
--- clang/test/Driver/split-debug.c
+++ clang/test/Driver/split-debug.c
@@ -68,18 +68,18 @@
 // RUN: FileCheck -check-prefix=CHECK-NOINLINE-WITHOUT-SPLIT < %t %s
 //
 // CHECK-NOINLINE-WITHOUT-SPLIT: "-fno-split-dwarf-inlining"
-// CHECK-NOINLINE-WITHOUT-SPLIT: "-debug-info-kind=limited"
+// CHECK-NOINLINE-WITHOUT-SPLIT: "-debug-info-kind=constructor"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gmlt -gsplit-dwarf -fno-split-dwarf-inlining -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-WITH-GMLT < %t %s
 //
-// CHECK-SPLIT-WITH-GMLT: "-debug-info-kind=limited"
+// CHECK-SPLIT-WITH-GMLT: "-debug-info-kind=constructor"
 // CHECK-SPLIT-WITH-GMLT: "-split-dwarf-output"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -fno-split-dwarf-inlining -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-WITH-NOINL < %t %s
 //
-// CHECK-SPLIT-WITH-NOINL: "-debug-info-kind=limited"
+// CHECK-SPLIT-WITH-NOINL: "-debug-info-kind=constructor"
 // CHECK-SPLIT-WITH-NOINL: "-split-dwarf-output"
 
 // RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -gmlt -fsplit-dwarf-inlining -S -### %s 2> %t
@@ -92,7 +92,7 @@
 // RUN: %clang -target x86_64-unknown-linux-gnu -gmlt -gsplit-dwarf -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-OVER-GMLT < %t %s
 //
-// CHECK-SPLIT-OVER-GMLT: "-debug-info-kind=limited"
+// CHECK-SPLIT-OVER-GMLT: "-debug-info-kind=constructor"
 // CHECK-SPLIT-OVER-GMLT: "-split-dwarf-file"
 // CHECK-SPLIT-OVER-GMLT: "-split-dwarf-output"
 
@@ -117,6 +117,6 @@
 // RUN: %clang -target x86_64-unknown-linux-gnu -g0 -gsplit-dwarf=split -S -### %s 2> %t
 // RUN: FileCheck -check-prefix=CHECK-SPLIT-OVER-G0 < %t %s
 //
-// CHECK-SPLIT-OVER-G0: "-debug-info-kind=limited"
+// CHECK-SPLIT-OVER-G0: "-debug-info-kind=constructor"
 // CHECK-SPLIT-OVER-G0: "-split-dwarf-file"
 // CHECK-SPLIT-OVER-G0: "-split-dwarf-output"
Index: clang/test/Driver/openmp-offload-gpu.c
===
--- clang/test/Driver/openmp-offload-gpu.c
+++ clang/test/Driver/openmp-offload-gpu.c
@@ -241,7 +241,7 @@
 
 // HAS_DEBUG-NOT: warning: debug
 // HAS_DEBUG: "-triple" "nvptx64-nvidia-cuda"
-// HAS_DEBUG-SAME: "-debug-info-kind={{limited|line-tables-only}}"
+// HAS_DEBUG-SAME: "-debug-info-kind={{constructor|line-tables-only}}"
 // HAS_DEBUG-SAME: "-dwarf-version=2"
 // HAS_DEBUG-SAME: "-fopenmp-is-device"
 // HAS_DEBUG: ptxas
Index: clang/test/Driver/myriad-toolchain.c
===
--- clang/test/Driver/myriad-toolchain.c
+++ clang/test/Driver/myriad-toolchain.c
@@ -83,7 +83,7 @@
 // NOSTDLIB-NOT: "-lc"
 
 // RUN: %clang -### -c -g %s -target sparc-myriad 2>&1 | FileCheck -check-prefix=G_SPARC %s
-// G_SPARC: "-debug-info-kind=limited" "-dwarf-version=2"
+// G_SPARC: "-debug-info-kind=constructor" "-dwarf-version=2"
 
 // RUN: %clang -### -c %s -target sparc-myriad-rtems -fuse-init-array 2>&1 \
 // RUN: | FileCheck -check-prefix=USE-INIT-ARRAY %s
Index: clang/test/Driver/integrated-as.s
===
--- clang/test/Driver/integrated-as.s
+++ clang/test/Driver/integrated-as.s
@@ -27,19 +27,19 @@
 // XA_INCLUDE2: "-Ifoo_dir"
 
 // RUN: %clang -### -target x86_64--- -c -integrated-as %s -gdwarf-4 -gdwarf-2 2>&1 | FileCheck --check-prefix=DWARF2 %s
-// DWARF2: "-debug-info-kind=limited" "-dwarf-version=2"
+// DWARF2: "-debug-info-kind=constructor" "-dwarf-version=2"
 
 // RUN: %clang -### -target x86_64--- -c -integrated-as %s -gdwarf-3 2>&1 | FileCheck --check-prefix=DWARF3 %s
-// DWARF3: "-debug-info-kind=limited" "-dwarf-version=3"
+//

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-10 Thread Fangrui Song via Phabricator via lldb-commits

MaskRay added a comment.

Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` 
`Subscribers:` `Tags:` and the text `Summary:` from the git commit with the 
following script:

  arcfilter () {
  arc amend
  git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} 
/Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: 
/,"");print}' | git commit --amend --date=now -F -
  }

`Reviewed By: ` is considered important by some people. Please keep the tag. 
(`--date=now` is my personal preference (author dates are usually not useful. 
Using committer dates can make log almost monotonic in time))

`llvm/utils/git/pre-push.py` can validate the message does not include unneeded 
tags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79147/new/

https://reviews.llvm.org/D79147



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-07 Thread David Blaikie via Phabricator via lldb-commits

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Could you include some comparative data in the description/commit message 
demonstrating this generally ends up emitting all the same types for a clang 
build before/after (& explanations for a sample of any differences)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79147/new/

https://reviews.llvm.org/D79147



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

6 matches

Site Navigation

Mail list logo

Footer information