[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd0af0cf0828: [lldb] [Process/Linux] Report fork/vfork stop reason (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny updated this revision to Diff 340187. mgorny added a comment. Add `multiprocess` to supported features. Tests were moved to earlier commit. Now this commit only enables the relevant category. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:402-403 + is_vfork ? StopReason::eStopReasonVFork : StopReason::eStopReasonFork; + m_stop_info.details.fork.child_pid = child_pid; + m_stop_info.details.fork.child_tid =

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D100208#2705891 , @mgorny wrote: > In D100208#2705455 , @labath wrote: > >> This seems reasonable. >> >>

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:932 + +std::unique_ptr child_process_up{child_process}; +Extension expected_ext = is_vfork ? Extension::vfork : Extension::fork; labath wrote: > Store

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny updated this revision to Diff 339350. mgorny marked 5 inline comments as done. mgorny added a comment. Implemented all the requests, modulo claim that PID and TID are duplicate ;-). Also found cases for `bool()` with `Extension` stuff. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny added a comment. In D100208#2705455 , @labath wrote: > This seems reasonable. > > Why don't we have tests that detach from the parent process (and maybe > continue the child)? Does that already work? (or in general, what is expected > to work

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

labath added a comment. Note that you don't actually have to use/extend this particular inferior for these tests. Feel free to create special purpose inferiors, if that's a better fit for the test, just like we do with "normal" tests... CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

labath added a comment. This seems reasonable. Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?) Comment at:

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny updated this revision to Diff 339257. mgorny retitled this revision from "[lldb] [Process/Linux] Report fork/vfork stop reason to client" to "[lldb] [Process/Linux] Report fork/vfork stop reason". mgorny edited the summary of this revision. mgorny added a comment. Now includes

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny updated this revision to Diff 337238. mgorny added a comment. Rebase. Store `mainloop` arg of the original process, and pass it to the children to make them independent of the 'main' process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny updated this revision to Diff 336670. mgorny added a comment. Report vfork-done stop to the client as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/ https://reviews.llvm.org/D100208 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny updated this revision to Diff 336657. mgorny added a comment. Copy software breakpoints to the forked process, to future-proof this patch for breakpoint support (I suppose there's no point in splitting it more). Add `GetSupportedExtensions()` to actually enable the new code. CHANGES

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny added a comment. Ok, found the culprit. Now it's ready ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/ https://reviews.llvm.org/D100208 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client [WIP]

mgorny added a comment. This is the final piece for moving minimal fork/vfork support to gdb-remote protocol. However, for some reason (unlike the original code in D99864 ), it crashes on random assertions about `m_enabled_extensions` value — probably memory

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client [WIP]

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Enable reporting fork/vfork events to the client when supported. This switches from implicit server-side handling to client-controlled gdb-remote protocol exchange.