[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

2021-04-15 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td:23 +DefaultUnsignedValue<0>, +Desc<"If greater than 0, sleep for packet-delay-multiplier * packet size nanoseconds for every packet sent or received.">; }

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

2021-04-15 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 added a comment. Hey @jasonmolenda thanks for the input, and nice empirical experiment! Do you think simply adding a setting that sleeps by a constant amount would be enough to model this problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

2021-04-14 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Hi Augusto, this is an interesting idea. This would simulate a slow serial connection well, but over a modern USB or Wifi or Bluetooth connection, we find the packet size is nearly irrelevant to performance -- but the number of packets is absolutely critical. If

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

2021-04-14 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps `PacketDelayMultiplier` nanoseconds per byte read or written in

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

2021-04-14 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 created this revision. augusto2112 added reviewers: jingham, jasonmolenda, clayborg. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100500 Files: