[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

shafik added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925 lldb::SBDeclaration declaration = v.GetDeclaration(); -std::string file_name(declaration.GetFileSpec().GetFilename()); const uint32_t line = declaration.GetLine();

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925 lldb::SBDeclaration declaration = v.GetDeclaration(); -std::string file_name(declaration.GetFileSpec().GetFilename()); const uint32_t line = declaration.GetLine();

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace updated this revision to Diff 341017. wallace added a comment. now checking if the strings gotten from the API are null or not CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101131/new/ https://reviews.llvm.org/D101131 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2939 break; variable_name_counts[variable.GetName()]++; } This

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 // We first find out which variable names are duplicated -llvm::DenseMap variable_name_counts; +std::map variable_name_counts; for (auto i = start_idx; i < end_idx; ++i) {

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace added a comment. TIL. I'll give it a try Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101131/new/ https://reviews.llvm.org/D101131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 // We first find out which variable names are duplicated -llvm::DenseMap variable_name_counts; +std::map variable_name_counts; for (auto i = start_idx; i < end_idx; ++i)

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace created this revision. wallace added reviewers: clayborg, teemperor. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As a follow up of https://reviews.llvm.org/D99989#inline-953343, I'm now storing std::string instead of