[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342354. flip1995 added a comment. Fix arc mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 343056. flip1995 added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342352. flip1995 marked 3 inline comments as done. flip1995 edited the summary of this revision. flip1995 added a comment. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

anirudhp added a comment. Hi @flip1995 My apologies, but you might have to rebase this on the latest main. I introduced a `MCSubtargetInfo` field in https://reviews.llvm.org/D100975. Some of the existing changes to the file may not be needed anymore. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay added a comment. In D101462#2733691 , @flip1995 wrote: > Not sure how the process from here on out is. I think it is important to > note, that I don't have push rights and someone else will have to land this > for me (I guess?). I'll keep this

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. > I'll keep this open for a few days as it touches too many things. Sounds good  I used `arc diff`. The commits I made with `git` have my name and email attached. But it seems like `arc` doesn't use them? I'll figure it out tomorrow, can't be that hard, I hope.

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

jrtc27 added a comment. In D101462#2739404 , @MaskRay wrote: > In D101462#2733726 , @flip1995 > wrote: > >>> I'll keep this open for a few days as it touches too many things. >> >> Sounds good  >> >>> but

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay added a comment. In D101462#2733726 , @flip1995 wrote: >> I'll keep this open for a few days as it touches too many things. > > Sounds good  > >> but you'll need to provide your name and email > > ~~I used `arc diff`. The commits I made with

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. Not sure how the process from here on out is. I think it is important to note, that I don't have push rights and someone else will have to land this for me (I guess?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632ebc4ab437: [MC] Untangle MCContext and MCObjectFileInfo (authored by flip1995, committed by MaskRay). Repository: rG LLVM Github Monorepo