[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

2021-09-14 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. I fixed this in e69d359841b6358f1d17569212ef8cf91244ca11 and fixed some style issues. --- This needs extra care. While Clang -Wformat flags printf("%llu", (size_t)3); warning: format

[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

2021-09-14 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo abandoned this revision. mstorsjo added a comment. Oh, sorry, I worked on a checkout a couple weeks old, where I ran into this warning. It does indeed seem to be fixed in the current git main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

2021-09-14 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a reviewer: MaskRay. bulbazord added a comment. Adding MaskRay who fixed something similar to this yesterday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109779/new/ https://reviews.llvm.org/D109779

[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

2021-09-14 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added a reviewer: labath. mstorsjo requested review of this revision. Herald added a project: LLDB. These variables are 'size_t' and thus should use %zu. On Windows, 'long' is always 32 bit. Repository: rG LLVM Github Monorepo