[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier added a comment. In D119186#3303744 , @sylvestre.ledru wrote: > Log: > https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console I downloaded build artifacts and it

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

sylvestre.ledru added a comment. Log: https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

sylvestre.ledru added a comment. Debian is still broken with this patch on -14: lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG385f5c4d3379: [lldb][CMake] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON (authored by mceier, committed by MaskRay). Changed prior to commit:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

MaskRay added a comment. In D119186#3303530 , @mceier wrote: > I need someone to merge it for me. Testing and merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier accepted this revision. mceier added a comment. I need someone to merge it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___ lldb-commits

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier updated this revision to Diff 406706. mceier added a comment. Updated diff to use LLDB_SYSTEM_LIBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 Files:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

raj.khem added a comment. I tested this patch and it fixes lldb build. Thanks for taking care of this,. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. In D119186#3302765 , @mceier wrote: > In D119186#3302612 , @JDevlieghere > wrote: > >> We should add this to `LLDB_SYSTEM_LIBS` like we do in >> `lldb/source/Host/CMakeLists.txt`

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier added a comment. In D119186#3302612 , @JDevlieghere wrote: > We should add this to `LLDB_SYSTEM_LIBS` like we do in > `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for > `lldbPluginProcessGDBRemote`. So should I add:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. Basically it should mirror what we have for LZMA: if (LLDB_ENABLE_LZMA) list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES}) endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We should add this to `LLDB_SYSTEM_LIBS` in `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for `lldbPluginProcessGDBRemote`. Repository: rG LLVM

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier created this revision. mceier added a reviewer: LLVM. Herald added a subscriber: mgorny. mceier requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLVM_ENABLE_ZLIB is ON gdb-remote should link with ZLIB::ZLIB. Fixes