Re: [Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

[Tamas Berghammer via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

I see your point. I am still not too happy with this approach but I don't have 
any better idea to solve it. I am fine with committing it in in this format and 
we can improve it later if we find a better approach.


http://reviews.llvm.org/D12025



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

[Oleksiy Vyalov via lldb-commits]

ovyalov added a comment.

In http://reviews.llvm.org/D12025#224355, @tberghammer wrote:

 The implementation looks good, but I don't like the approach you try to 
 handle the problem.

 I think you do far too much work to use UriParser in a case where it isn't 
 necessary and isn't make things easier. I think a better (and definitely 
 simpler) solution would be to change only ConnectionFileDescriptorPosix.cpp 
 to parse the adb addresses with a locally specified regexp or with looking 
 for the last colon in the address and split the address to host and port 
 based on that.


The problem that connection url goes all way down 
PlatformAndroid::ConnectRemote- 
PlatformAndroidRemoteGDBServer::ConnectRemote-PlatformRemoteGDBServer::ConnectRemote
 whiles it reaches ConnectionFileDescriptorPosix::Connect. Within each 
ConnectRemote we call UriParser::Parse  - either to verify url correctness or 
fetch device_id from adb url. In this case we may need to have special handling 
for adb protocol inside of UriParser::Parse to pass it through  - I'm not very 
happy to bring protocol-specific knowledge to this class.


http://reviews.llvm.org/D12025



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits