dawn planned changes to this revision.
dawn added a comment.
In http://reviews.llvm.org/D12115#227613, @abidh wrote:
This command uses target modules lookup [...]
Good point. Yes, it would be good to encapsulate this. I'll rework this patch
accordingly when I can find the time (busy with a
Seems reasonable to move that to lldb-dev.
On Wed, Aug 19, 2015 at 12:56 PM Dawn Perchik dawn+l...@burble.org wrote:
dawn planned changes to this revision.
dawn added a comment.
In http://reviews.llvm.org/D12115#227613, @abidh wrote:
This command uses target modules lookup [...]
Good
Rather than all of this ugly error-prone code, can we instead use
llvm::sys::fs::root_name to check whether the path contains a drive letter?
On Tue, Aug 18, 2015 at 1:52 PM Dawn Perchik via lldb-commits
lldb-commits@lists.llvm.org wrote:
dawn created this revision.
dawn added reviewers:
dawn added a comment.
In http://reviews.llvm.org/D12115#227241, @brucem wrote:
... this needs a test as well if possible.
Since the lldb-mi tests don't run on Windows, I don't see how that would be
possible.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
dawn added a comment.
Are you saying that there is a situation where you are given a path, and you
have no idea whether it is a posix path or a windows path?
Yes. For example, in lldb on OSX, we can be debugging an app that was built on
OSX, or an app that was built on Windows targeting
