labath added a comment.
Yeah, I'm pretty sure its due to this patch. Though the failures don't look
near as bad as I feared. :)
I've reverted the patch while I work on a fix. Do let me know if you see some
other failures related to this, particularly in some more exotic
shafik added a comment.
I think this PR broke green dragon incremental build:
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/42185/
It looks like the failures are all related to platforms in some ways.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdddf4ce034a8: [lldb/test] Make category-skipping logic
platform-independent (authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121605/new/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125
def getPlatform():
"""Returns the target platform which the tests are
labath added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125
def getPlatform():
"""Returns the target platform which the tests are running on."""
I'm not sure if this will work for all apple platforms. Can I
labath created this revision.
labath added reviewers: JDevlieghere, jingham, clayborg.
Herald added a project: All.
labath requested review of this revision.
Herald added a project: LLDB.
The decision which categories are relevant for a particular test run
happen very early in the test setup
