This revision was automatically updated to reflect the committed changes.
Closed by commit rG195a8b977efe: dont extra notify ModulesDidLoad() from
LoadModuleAtAddress() (authored by llunak).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123128/new/
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123128/new/
https://reviews.llvm.org/D123128
___
lldb-commits mailing list
llunak updated this revision to Diff 421782.
llunak edited the summary of this revision.
llunak added a comment.
Changed to always disable notify and added a comment about that to
LoadModuleAtAddress().
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123128/new/
labath added a comment.
> Note that this patch could have been shorter if I simply changed
> LoadModuleAtAddress() to always pass false for notify (all callers currently
> call ModulesDidLoad() afterwards) and added a note to LoadModuleAtAddress()
> docs about it, but I don't know if that's a
llunak created this revision.
llunak added a reviewer: jasonmolenda.
llunak added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
llunak requested review of this revision.
Herald added a subscriber: lldb-commits.
Places calling LoadModuleAddress() already
