clayborg accepted this revision.
clayborg added a comment.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13201
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
enlight updated this revision to Diff 36468.
enlight added a comment.
Added a couple of unit tests, the Windows-specific cleanups will be submitted
in a separate patch.
Repository:
rL LLVM
http://reviews.llvm.org/D13201
Files:
source/Host/common/Symbols.cpp
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks great, thanks
Repository:
rL LLVM
http://reviews.llvm.org/D13201
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.
I know you are just following the existing pattern, but this whole function
appears broken in the presence of file systems that use backslash instead of
forward slash. Could you
brucem added a comment.
Talking to Vadim (enlight) offline, this happened when debugging an inferior on
a Linux target from a Windows host. He had only copied the executable back to
the Windows host, so the shared libraries involved weren't present on his
system.
I'm not sure if this is the
enlight added a comment.
I've updated the summary with the scenario. I don't know how one would go about
writing a test for this, mixed platform remote debugging is a bit finicky.
Comment at: source/Host/common/Symbols.cpp:238-250
@@ -237,15 +237,15 @@
// Add
zturner added a comment.
As for the test, this could be a good candidate for a unit test. It's not
advertised very well so there's definitely some work for us to do on that
front, but basically you can run `ninja check-lldb-unit`. Seems like you could
just create a `ModuleSpec` on the stack,
