Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-10-06 Thread Zachary Turner via lldb-commits
zturner added a comment. My change to support Python 3 is in. Now that that's in, would you mind trying to prettify the output messages when you get a chance? Repository: rL LLVM http://reviews.llvm.org/D13234 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-10-02 Thread Zachary Turner via lldb-commits
zturner added a comment. Hi Vadim, when I run CMake with this change I get the following output: [1/1] Re-running CMake... - Warning: Did not find file Compiler/MSVC-ASM - Target triple: i686-pc-win32 - Native target architecture is X86 - Threads enabled. - Doxygen disabled. - Sphinx disabled.

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-10-02 Thread Vadim Macagon via lldb-commits
enlight added a comment. That looks fine to me. CMake prints those messages during the configuration step, at that point the generator expressions haven't been expanded yet. I could prettify those messages a bit to read: `Found PythonLibs: C:/Python27_LLDB/x86/libs/python27_d.lib and

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-10-02 Thread Zachary Turner via lldb-commits
Yea that's what I meant. Everything works, but the configuration step is supposed to print out stuff that people can read at a glance. So prettifying it would be desirable. On Fri, Oct 2, 2015 at 10:39 PM Vadim Macagon wrote: > enlight added a comment. > > That looks

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-10-01 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248991: Use the correct Python lib for each build configuration generated by the… (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13234?vs=36072=36196#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-09-30 Thread Vadim Macagon via lldb-commits
enlight planned changes to this revision. enlight added a comment. I'll submit a revised patch that contains an explanation of the generator expressions to aid future maintainers/contributors. Comment at: cmake/modules/LLDBConfig.cmake:61 @@ +60,3 @@ + # below, otherwise

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-09-30 Thread Zachary Turner via lldb-commits
Ok, looks good On Wed, Sep 30, 2015 at 12:27 AM Vadim Macagon wrote: > enlight updated this revision to Diff 36072. > enlight added a comment. > This revision is now accepted and ready to land. > > Added an explanation of the generator expression used in this patch. > >

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

2015-09-29 Thread Bruce Mitchener via lldb-commits
brucem added a comment. This looks good to me and like the correct fix. Leaving it for zturner to give the official nod of approval though. Repository: rL LLVM http://reviews.llvm.org/D13234 ___ lldb-commits mailing list