[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-09 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1f47352ce7e8: Document some of the clang-specific DWARF extensions supported by LLDB (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-09 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. cool Comment at: lldb/docs/use/extensions.rst:84 + DW_TAG_compile_unit + DW_AT_GNU_dwo_id (0xabcdef) + DW_AT_GNU_dwo_name("M.pcm") Michael137 wrote: > Is it worth commenting on the

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-09 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added inline comments. Comment at: lldb/docs/use/extensions.rst:84 + DW_TAG_compile_unit + DW_AT_GNU_dwo_id (0xabcdef) + DW_AT_GNU_dwo_name("M.pcm") Is it worth commenting on the difference to the `dwo` mechanism on Linux. Since we

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-09 Thread Michael Buch via Phabricator via lldb-commits
Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-08 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Content looks good to me, but I'll hold off on accepting the review until the others have had a chance to see this in their review queue. Comment at: lldb/docs/use/extensions.rst:72 + +:: + DW_TAG_compile_unit Missing newline

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-08 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 458839. aprantl added a comment. Herald added a subscriber: arphaman. Wire up the ToC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 Files: lldb/docs/index.rst lldb/docs/use/extensions.rst Index:

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-08 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. You'll need to add this to the index.rst page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

2022-09-08 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: JDevlieghere, Michael137, jingham, labath. Herald added a project: All. aprantl requested review of this revision. This patch adds a new page to the LLDB documentation that documents, among other things the `-gmodules` debug info format.