[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

2022-09-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/API/SBError.h:95 private: - std::unique_ptr m_opaque_up; + std::shared_ptr m_opaque_sp; This is technically an ABI break (changes `sizeof(SBError)`). I don't care, but someone might.

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

2022-09-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:186 + StatusSP status_sp = std::make_shared(error); + PythonObject* sb_error = new PythonObject(ToSWIGWrapper(status_sp)); + @labath In

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

2022-09-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should improve error reporting by passing the status object from the Scripted