This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf0cda9ed278: [lldb][COFF] Rewrite ParseSymtab to list both
export and symbol tables (authored by alvinhochun, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
alvinhochun updated this revision to Diff 462471.
alvinhochun added a comment.
Updated the test to include more symbols used in later changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134196/new/
https://reviews.llvm.org/D134196
Files:
mstorsjo added a comment.
This looks good to me, nothing to add from my PoV. Nice to have this condensed
to a small enough rewrite, with few enough functional changes to wrap one's
head around.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
alvinhochun marked 2 inline comments as done.
alvinhochun added a comment.
Thanks for reviewing. The COFF symbol table seems to be used by MinGW binaries
in conjunction with DWARF debugging symbols. Some symbols (those added by the
linker in particular) are not included in the DWARF symbol. I
alvinhochun updated this revision to Diff 461496.
alvinhochun added a comment.
Updated test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134196/new/
https://reviews.llvm.org/D134196
Files:
labath added a comment.
I don't know how coff symbol tables work, but this seems reasonable to me.
Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbols-export-table.yaml:10
+# CHECK-NEXT: D Code 0x0001800010100x{{[0-9a-f]+}}
0x{{[0-9a-f]+}} exportfunc
+#
alvinhochun created this revision.
alvinhochun added reviewers: labath, DavidSpickett, mstorsjo.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
This reimplements
