Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added inline comments. Comment at: tools/lldb-server/CMakeLists.txt:42 @@ +41,3 @@ + if (LLDB_VERS_GENERATED_FILE) +add_dependencies(lldb-server swig_wrapper) + endif() brucem wrote: > Why is this needed? You get undefined symbol otherwise (if you

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added inline comments. Comment at: tools/lldb-server/CMakeLists.txt:42 @@ +41,3 @@ + if (LLDB_VERS_GENERATED_FILE) +add_dependencies(lldb-server swig_wrapper) + endif() dawn wrote: > brucem wrote: > > Why is this needed? > You get undefined symbol

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

brucem added a comment. I think what needs to happen is that you take the `add_custom_command` and then create a target that will execute the command and only do it once ... I'll provide an example from something else shortly. (I was about to request changes here when you committed it and

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added a comment. In http://reviews.llvm.org/D13535#262672, @brucem wrote: > I don't know what's broken for you. My build hasn't had any issues on Mac OS > X using cmake. In a clean workspace, cmake would fail because LLDB_vers.c hadn't been created yet. You get the error: CMake

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

brucem added a comment. I don't know what's broken for you. My build hasn't had any issues on Mac OS X using cmake. Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added a comment. I went ahead and committed this since the build was completely broken - I'd be happy to apply any suggestions folks make here in subsequent commits. Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added a comment. FYI - our Jenkins master build just picked up the change and is finally building again - yay!! :) Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249684: [cmake] Fix cmake build on OSX after r249434. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D13535?vs=36798=36846#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

brucem added a comment. The way to do this correctly is something like ADD_CUSTOM_COMMAND( OUTPUT whatever.output.file.c COMMAND ... whatever ... DEPENDS ... whatever ... ) ADD_CUSTOM_TARGET(whatever-target-name ALL DEPENDS

[Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn created this revision. dawn added reviewers: sas, clayborg, zturner. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This fixes the cmake build on OSX when building in a new workspace. It reverts r249434 and instead fixes the issue as proposed

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

zturner added a comment. I can't verify that this works on MacOSX at the moment. Did you verify that this works on other platforms as well? Repository: rL LLVM http://reviews.llvm.org/D13535 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

dawn added a comment. In http://reviews.llvm.org/D13535#262225, @zturner wrote: > I can't verify that this works on MacOSX at the moment. Did you verify that > this works on other platforms as well? I've confirmed it works on MacOSX - I'll try to test Linux later today if no one beats me to

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

lgtm is just as good as hitting accept in Phabricator, I just can't login to Phab right now so I'm using email. Feel free to commit On Wed, Oct 7, 2015 at 8:24 PM Dawn Perchik wrote: > dawn added a comment. > > Can someone accept this patch so I can commit please? > > >

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

Ok, lgtm then. On Wed, Oct 7, 2015 at 7:25 PM Dawn Perchik wrote: > dawn added a comment. > > Works fine on Linux too. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D13535 > > > > ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13535: Fix cmake build on OSX after r249434.

brucem added a subscriber: brucem. Comment at: tools/lldb-server/CMakeLists.txt:42 @@ +41,3 @@ + if (LLDB_VERS_GENERATED_FILE) +add_dependencies(lldb-server swig_wrapper) + endif() Why is this needed? Repository: rL LLVM http://reviews.llvm.org/D13535