[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb924c8c71daa: [clang][LTO] Remove the use of `--` for arange option (authored by Qiongsi Wu qiongs...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Qiongsi Wu via Phabricator via lldb-commits
qiongsiwu1 updated this revision to Diff 465910. qiongsiwu1 added a comment. Thanks for the review! Comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files:

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-aranges.c:6 // RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck %s -// CHECK:

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Qiongsi Wu via Phabricator via lldb-commits
qiongsiwu1 added a comment. In D135400#3841321 , @MaskRay wrote: > I missed https://reviews.llvm.org/D134668 . See my comment there I don't > think the change is necessary. Thanks for the comment! I posted a reply there. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 ___ lldb-commits

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Qiongsi Wu via Phabricator via lldb-commits
qiongsiwu1 updated this revision to Diff 465872. qiongsiwu1 added a comment. Fix a patch upload error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

2022-10-06 Thread Qiongsi Wu via Phabricator via lldb-commits
qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, azat, dblaikie. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: