Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL265377.
Repository:
rL LLVM
https://reviews.llvm.org/D13578
___
lldb-commits mailing l
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:859-870
@@ -853,1 +858,14 @@
+
+// If this and other are both arm ArchSpecs and this ArchSpec is a generic
"some kind of arm"
+// spec but the other ArchSpec is a specific arm core, adopt the specific
jasonmolenda updated this revision to Diff 37210.
jasonmolenda added a comment.
Quick update of the patch using the llvm target information. Builds and works
correctly on macosx with xcodebuild. Doesn't build with cmake yet; I don't
have the includes set up correctly for the llvm build-dir lib
rengolin added a comment.
In http://reviews.llvm.org/D13578#264072, @jasonmolenda wrote:
> I'm trying to rewrite IsAlwaysThumbInstructions() to use the information that
> llvm already has, as per Renato's suggestion. The MCSubtargetInfo has a
> getFeatureBits() method which can indicate ARM::F
jasonmolenda added a comment.
Hi Renato & Tamas, thanks for the feedback.
I'm trying to rewrite IsAlwaysThumbInstructions() to use the information that
llvm already has, as per Renato's suggestion. The MCSubtargetInfo has a
getFeatureBits() method which can indicate ARM::FeatureNoARM. I'm sti
tberghammer added a comment.
In general I like the approach you are taking and creating
IsAlwaysThumbInstructions sounds like a good idea, but I would implement it a
bit differently.
llvm::Triple already contains a SubArch field what is filled in from the first
part of the triple in case of ar
rengolin added a comment.
Hi Jason,
This has nothing to do with your patch per se, but we have accurate target
descriptions in LLVM, and the parser for all the triples and extra options is
now publicly available, so I was wondering if (probably after this go in), you
could have a look at using
jasonmolenda created this revision.
jasonmolenda added a reviewer: tberghammer.
jasonmolenda added subscribers: lldb-commits, clayborg.
jasonmolenda set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
This patch is to address a few issues I came up with w
