Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.

2015-10-26 Thread Zachary Turner via lldb-commits
zturner added a comment. Do we need this `GetScheme()` method? And instead of having `Create` take a string, couldn't it just take a `SocketProtocol` instead? It seems like the logic of converting the string to the enum should be done in the `Acceptor` class, as this URI format is defined by

Re: [Lldb-commits] [PATCH] D14085: Add Socket::Create factory method which uses socket scheme (tcp, unix, ..) to find an appropriate implementation class.

2015-10-26 Thread Oleksiy Vyalov via lldb-commits
ovyalov retitled this revision from "Make Socket to support plugin interface" to "Add Socket::Create factory method which uses socket scheme (tcp, unix,..) to find an appropriate implementation class.". ovyalov updated the summary for this revision. ovyalov updated this revision to Diff 38484.