[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

JDevlieghere updated this revision to Diff 487613. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Make `lldb-framework-cleanup` a dependency of `install-liblldb`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141021/new/ https://reviews.llvm.org/D141021

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

JDevlieghere added a comment. In D141021#4037840 , @bulbazord wrote: > I think this idea will work but I have a few comments and questions: > > Based on my understanding of this change, we're supposed to manually run the > build system with the target

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

mib added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:247-249 + # Create a target to remove the target again before the install phase. We + # intentionally use remove_directory because the target can be a directory + # and it's harmless for files.

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

bulbazord added a comment. I think this idea will work but I have a few comments and questions: Based on my understanding of this change, we're supposed to manually run the build system with the target `lldb-framework-cleanup` before we perform an install. Is this the case? This seems most

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, mib. Herald added a project: All. JDevlieghere requested review of this revision. CMake supports building Framework bundles for Apple platforms. We rely on this functionality to create LLDB.framework. From CMake's