Re: [Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.

2015-11-05 Thread Zachary Turner via lldb-commits
zturner added a comment. Seems ok I suppose, I can't find any functional changes from eyeballing it aside from the import changes. I'm still confused why `utilsDebug.py` even worked before Comment at: scripts/utilsDebug.py:14 @@ -16,2 +13,3 @@ # Python modules: +import sys

Re: [Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.

2015-11-05 Thread Bruce Mitchener via lldb-commits
brucem added inline comments. Comment at: scripts/Python/buildSwigPython.py:293 @@ +292,3 @@ +# LLDBWrapPython.cpp file. +# Args:vDictArg - (R) Program input parameters. +# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file. I shouldn't

Re: [Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.

2015-11-05 Thread Bruce Mitchener via lldb-commits
brucem added a comment. Even if it were, in some of the files, almost every line would change anyway due to semicolons and then due to incorrect whitespace. http://reviews.llvm.org/D14375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org