chaoren added a comment.
It's not actually CMake complaining but the LLVM cmake scripts.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Isn't this going to have the same problem as before? If CMake finds a source
file in the directory that is not added to one of the targets, it will give you
an error. With this patch, on Linux or Windows `PlatformAppleSimulator.cpp`
will be on disk, but not part of
chaoren added a comment.
LLVM_OPTIONAL_SOURCES should avoid that.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chaoren created this revision.
chaoren added reviewers: granata.enrico, tberghammer, zturner, jingham.
chaoren added a subscriber: lldb-commits.
This is a resubmission of r252179, but correctly ignores the source
files for other platforms.
http://reviews.llvm.org/D14389
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252205: Completely avoid building Apple simulator on
non-Darwin platforms. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14389?vs=39394=39402#toc
Repository:
rL LLVM
chaoren added a comment.
I haven't seen anything else that uses LLVM_OPTIONAL_SOURCES, but it's
conceivable that there might be items in the list already, and I would like to
avoid doing anything to it besides just appending.
http://reviews.llvm.org/D14389
zturner added a comment.
Ahh makes sense, I didn't know about that. I think a cleaner way to do this is
to just add everything to `PLUGIN_PLATFORM_MACOSX_SOURCES` in the very first
`list(APPEND)`. Then just do this:
if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I find the code to be a fair bit harder to understand as a result, but I guess
it's not the end of the world.
Searching the source of LLVM's CMake infrastructure, this variable exists
