Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

2015-11-06 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks reasonable. Do we know if it runs anywhere else yet? http://reviews.llvm.org/D14395 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

2015-11-06 Thread Zachary Turner via lldb-commits
zturner added a comment. I'm probably being dense. But do we know if what runs anywhere else? http://reviews.llvm.org/D14395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

2015-11-06 Thread Todd Fiala via lldb-commits
tfiala added a comment. I meant I looked at it but didn't try to run it (on Linux or OS X), and was wondering if you had tried to run it on a non-Windows platform. http://reviews.llvm.org/D14395 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

2015-11-06 Thread Zachary Turner via lldb-commits
Ahh, no sorry. There's nothing platform specific in the patch though, so I don't anticipate any problems on that front. I did run it under 2.7 and it worked, so I expect it will run under 2.7 on other platforms. On Fri, Nov 6, 2015 at 1:42 PM Todd Fiala wrote: > tfiala

[Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

2015-11-05 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. TBH I'm honestly not sure what the problem was before, or why this fixes it. But what I can tell from debugging is that under Py3, `sortMethodsUsing` is treated as a class