This revision was automatically updated to reflect the committed changes.
Closed by commit rL252330: [swig] Remove
check_lldb_swig_executable_file_exists. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14415?vs=39558=39562#toc
Repository:
rL LLVM
zturner added a comment.
Eh, just delete it IMO. I don't like leaving code around "just in case".
These scripts already need to be practically re-written (due to not using the
standard argparse module), the less work we have to do the better. CMake is
the only user of this script as far as
brucem updated this revision to Diff 39558.
brucem added a comment.
Instead of simplifying, just remove. Expand scope of removal as well.
http://reviews.llvm.org/D14415
Files:
scripts/Python/buildSwigPython.py
scripts/buildSwigWrapperClasses.py
Index: scripts/buildSwigWrapperClasses.py
zturner added a comment.
If it's never used in practice, can you just delete the codepath entirely? I'm
a strong proponent of deleting code that nobody cares about. (Of course, if
you found this because you do care about it and this codepath didn't work when
you tried to use it, that's a
brucem added a comment.
Well, I'm pretty sure ... but I don't know if someone in some configuration or
set of build arrangements might use it. It might also be used if we ever make
the Makefiles or xcode projects use these scripts.
http://reviews.llvm.org/D14415
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
