Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala added a subscriber: tfiala. tfiala added a comment. (Which I guess means Greg, seeing Enrico's comment earlier!) http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala resigned from this revision. tfiala removed a reviewer: tfiala. tfiala added a comment. Zachary, I am going to defer to Enrico on this. He has better context. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala added a comment. Okay Greg's not had a chance to look at this. I just had a look at it. I'm okay with it, Zachary. Feel free to check it in. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner added inline comments. Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:369-374 @@ +368,8 @@ + +template +T +ResolveNameAs(llvm::StringRef name) const +{ +return ResolveName(name).AsType(); +} +}; I need

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

On Mon, Nov 9, 2015 at 5:22 PM Zachary Turner wrote: > zturner created this revision. > zturner added reviewers: granata.enrico, clayborg, tfiala. > zturner added a subscriber: lldb-commits. > > The goal here is to eventually replace some code in `python-wrapper.swig` > with

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

granata.enrico added a comment. This seems reasonable to me. I would wait for Greg to OK it, just to be safe. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner created this revision. zturner added reviewers: granata.enrico, clayborg, tfiala. zturner added a subscriber: lldb-commits. The goal here is to eventually replace some code in `python-wrapper.swig` with this code. This way it can be properly unit tested and we can easily deal with

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

zturner updated this revision to Diff 39776. zturner added a comment. Fix some indentation http://reviews.llvm.org/D14524 Files: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h