dawn added a comment.
In http://reviews.llvm.org/D14631#289917, @tberghammer wrote:
> How you end up in calling DWARFFormValue::Address() with a value what have a
> form type other then DW_FORM_addr and DW_FORM_GNU_addr_index? What is the
> attribute tag and the form type used? Can you post a
tberghammer added a comment.
The feature Greg mentioned is already implemented in
DWARFDebugInfoEntry::GetAttributeHighPC and we shouldn't move it to
DWARFFormValue::Address because it is only needed for DW_AT_high_pc but
DWARFFormValue::Address used for other places as well (e.g.
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
(Next time please upload the diff with full context because it is easier to
review that way)
Repository:
rL LLVM
http://reviews.llvm.org/D14631
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This is not the right fix. Compilers that emit addresses with DW_FORM_data*
forms are saying that this address is an offset from the DW_AT_low_pc so this
function will not
dawn abandoned this revision.
dawn added a comment.
> If you have a compiler that is actually emitting addresses incorrectly using
> DW_FORM_data* when the values are not offsets, the compiler should be fixed.
Thanks Greg! In this case it indeed appears to be a compiler bug (we are
getting
dawn created this revision.
dawn added reviewers: tberghammer, clayborg, tfiala.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Other compilers (and older Clang compilers) use data4/data8 forms to specify
addresses in DWARF. This patch fixes lldb to
