[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord abandoned this revision. bulbazord added a comment. I'm abandoning this approach in favor of what Pavel suggested: https://reviews.llvm.org/D147084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord planned changes to this revision. bulbazord added a comment. In D147009#4227163 , @labath wrote: > I already regret getting involved in this, but here it goes... Your effort and participation is greatly appreciated. I'm sorry if this is

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

labath added a comment. I already regret getting involved in this, but here it goes... Do you actually expect we will have multiple ObjectFile subclasses implementing the `ObjectFileCreateInstanceWithDelegate` interface? Because if not, then I think this is just a very roundabout way of being

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

mib added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:28 -class ObjectFileJITDelegate { +class ObjectFileDelegate { public: nit: What about nesting this in the `ObjectFile` class and rename it to `Delegate`. I would be better in term

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord updated this revision to Diff 508817. bulbazord added a comment. Herald added a subscriber: Michael137. Minor fix to ObjectFileWasm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/ https://reviews.llvm.org/D147009 Files:

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, clayborg, mib, jingham. Herald added subscribers: pmatos, asb, sbc100, emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin.