[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers closed this revision. nickdesaulniers added a comment. Let's use D148546 as the reland (sorry, couldn't get arcanist to work to reuse this instance of code review reopened). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers closed this revision. nickdesaulniers added a comment. Creating https://reviews.llvm.org/D148546 instead; `arcanist` really doesn't like how I've reopened this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 514306. nickdesaulniers added a comment. This revision is now accepted and ready to land. - reopen with D148392 folded in, and 3 additional fixes for windows as reported by buildbots CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + MaskRay wrote: > chapuni wrote: > > Odd layering... > Good catch. LLVMDemangle cannot depend on other LLVM libraries. If these are inline function

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. In D148384#4270505 , @dhoekwater wrote: > It looks like this breaks the build: > https://lab.llvm.org/buildbot#builders/119/builds/12865 > https://lab.llvm.org/buildbot#builders/123/builds/18388 >

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

MaskRay added a comment. In D148384#4270505 , @dhoekwater wrote: > It looks like this breaks the build: > https://lab.llvm.org/buildbot#builders/119/builds/12865 > https://lab.llvm.org/buildbot#builders/123/builds/18388 >

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

dhoekwater added a comment. It looks like this breaks the build: https://lab.llvm.org/buildbot#builders/119/builds/12865 https://lab.llvm.org/buildbot#builders/123/builds/18388 https://lab.llvm.org/buildbot#builders/60/builds/11628 I'm pretty new with LLVM so I'll leave reverting the change

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

MaskRay added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + chapuni wrote: > Odd layering... Good catch. LLVMDemangle cannot depend on other LLVM libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

chapuni added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + Odd layering... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. In D148384#4270106 , @nickdesaulniers wrote: > These windows buildbot failures are tough to make out: > https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio > > [2/1778] Building CXX object >

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. These windows buildbot failures are tough to make out: https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio [2/1778] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\DLangDemangle.cpp.obj FAILED:

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e559509b426: [Demangle] replace use of llvm::StringView w/ std::string_view (authored by nickdesaulniers). Herald added a subscriber: JDevlieghere.

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 513779. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fix lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION