Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL254853: Define new builder_netbsd (authored by kamil).

Changed prior to commit:
  http://reviews.llvm.org/D15065?vs=41363=41991#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D15065

Files:
  lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
  lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py

Index: lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
+++ lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
@@ -0,0 +1,4 @@
+from builder_base import *
+
+def buildDsym(sender=None, architecture=None, compiler=None, dictionary=None, 
clean=True):
+return False
Index: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
@@ -430,6 +430,8 @@
 def builder_module():
 if sys.platform.startswith("freebsd"):
 return __import__("builder_freebsd")
+if sys.platform.startswith("netbsd"):
+return __import__("builder_netbsd")
 return __import__("builder_" + sys.platform)
 
 def run_adb_command(cmd, device_id):


Index: lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
+++ lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
@@ -0,0 +1,4 @@
+from builder_base import *
+
+def buildDsym(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
+return False
Index: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
@@ -430,6 +430,8 @@
 def builder_module():
 if sys.platform.startswith("freebsd"):
 return __import__("builder_freebsd")
+if sys.platform.startswith("netbsd"):
+return __import__("builder_netbsd")
 return __import__("builder_" + sys.platform)
 
 def run_adb_command(cmd, device_id):
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Todd Fiala via lldb-commits]

tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

I'm not sure exactly how these were divided up initially, but I'd suspect a 
substantial amount of it is similar along the vein of POSIX vs. non-POSIX, 
probably with some diffs for OS X supporting frameworks, dsyms, etc.  More than 
likely this fracturing happened because it was first just OS X, then some combo 
of FreeBSD and Linux.

I'd be okay with this as is for now, but we should probably file a bugzilla to 
go back and see if at least the Linux, FreeBSD and NetBSD ones can be combined 
(and perhaps even OS X).  But I'd need to spend some time looking, which I 
haven't done here.


Repository:
  rL LLVM

http://reviews.llvm.org/D15065



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Kamil Rytarowski via lldb-commits]

krytarowski added a comment.

In http://reviews.llvm.org/D15065#298279, @zturner wrote:

> This doesn't look substantially different than builder_freebsd.  Assuming
>  there is no practical difference, how about just using that for both
>  freebsd and netbsd?


The linux2, win32 and freebsd targets have the files with the same content. I 
dislike the idea to share it only between FreeBSD and NetBSD.


Repository:
  rL LLVM

http://reviews.llvm.org/D15065



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Kamil Rytarowski via lldb-commits]

krytarowski created this revision.
krytarowski added reviewers: emaste, tfiala.
krytarowski added subscribers: joerg, lldb-commits.
krytarowski set the repository for this revision to rL LLVM.

This is used in tests.

Repository:
  rL LLVM

http://reviews.llvm.org/D15065

Files:
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/plugins/builder_netbsd.py

Index: packages/Python/lldbsuite/test/plugins/builder_netbsd.py
===
--- /dev/null
+++ packages/Python/lldbsuite/test/plugins/builder_netbsd.py
@@ -0,0 +1,4 @@
+from builder_base import *
+
+def buildDsym(sender=None, architecture=None, compiler=None, dictionary=None, 
clean=True):
+return False
Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -430,6 +430,8 @@
 def builder_module():
 if sys.platform.startswith("freebsd"):
 return __import__("builder_freebsd")
+if sys.platform.startswith("netbsd"):
+return __import__("builder_netbsd")
 return __import__("builder_" + sys.platform)
 
 def run_adb_command(cmd, device_id):


Index: packages/Python/lldbsuite/test/plugins/builder_netbsd.py
===
--- /dev/null
+++ packages/Python/lldbsuite/test/plugins/builder_netbsd.py
@@ -0,0 +1,4 @@
+from builder_base import *
+
+def buildDsym(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):
+return False
Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -430,6 +430,8 @@
 def builder_module():
 if sys.platform.startswith("freebsd"):
 return __import__("builder_freebsd")
+if sys.platform.startswith("netbsd"):
+return __import__("builder_netbsd")
 return __import__("builder_" + sys.platform)
 
 def run_adb_command(cmd, device_id):
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Zachary Turner via lldb-commits]

Ok, if there's already precedent for duplicating the files then go ahead
and follow the pattern.  Although I'm not sure I'm crazy about duplicating
files on the off chance that something might be different someday.

In any case, lgtm.

On Sun, Nov 29, 2015 at 8:01 PM Kamil Rytarowski  wrote:

> krytarowski added a comment.
>
> In http://reviews.llvm.org/D15065#298279, @zturner wrote:
>
> > This doesn't look substantially different than builder_freebsd.  Assuming
> >  there is no practical difference, how about just using that for both
> >  freebsd and netbsd?
>
>
> The linux2, win32 and freebsd targets have the files with the same
> content. I dislike the idea to share it only between FreeBSD and NetBSD.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15065
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Zachary Turner via lldb-commits]

zturner added a subscriber: zturner.
zturner added a comment.

This doesn't look substantially different than builder_freebsd.  Assuming
there is no practical difference, how about just using that for both
freebsd and netbsd?


Repository:
  rL LLVM

http://reviews.llvm.org/D15065



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15065: Define new builder_netbsd

[Zachary Turner via lldb-commits]

This doesn't look substantially different than builder_freebsd.  Assuming
there is no practical difference, how about just using that for both
freebsd and netbsd?

On Sun, Nov 29, 2015 at 6:17 PM Kamil Rytarowski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> krytarowski created this revision.
> krytarowski added reviewers: emaste, tfiala.
> krytarowski added subscribers: joerg, lldb-commits.
> krytarowski set the repository for this revision to rL LLVM.
>
> This is used in tests.
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15065
>
> Files:
>   packages/Python/lldbsuite/test/lldbtest.py
>   packages/Python/lldbsuite/test/plugins/builder_netbsd.py
>
> Index: packages/Python/lldbsuite/test/plugins/builder_netbsd.py
> ===
> --- /dev/null
> +++ packages/Python/lldbsuite/test/plugins/builder_netbsd.py
> @@ -0,0 +1,4 @@
> +from builder_base import *
> +
> +def buildDsym(sender=None, architecture=None, compiler=None,
> dictionary=None, clean=True):
> +return False
> Index: packages/Python/lldbsuite/test/lldbtest.py
> ===
> --- packages/Python/lldbsuite/test/lldbtest.py
> +++ packages/Python/lldbsuite/test/lldbtest.py
> @@ -430,6 +430,8 @@
>  def builder_module():
>  if sys.platform.startswith("freebsd"):
>  return __import__("builder_freebsd")
> +if sys.platform.startswith("netbsd"):
> +return __import__("builder_netbsd")
>  return __import__("builder_" + sys.platform)
>
>  def run_adb_command(cmd, device_id):
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits