[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits 
DavidSpickett added a comment.

I was going to wait for some Mac specific reviewer too but it's simple and the 
Green Dragon bots should verify it well enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158391/new/

https://reviews.llvm.org/D158391

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7549cde6bd52: [lldb][debugserver] Fix build after libcxx 
removed generic char_traits… (authored by DavidSpickett).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158391/new/

https://reviews.llvm.org/D158391

Files:
  lldb/tools/debugserver/source/RNBRemote.cpp


Index: lldb/tools/debugserver/source/RNBRemote.cpp
===
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -2585,7 +2585,7 @@
   // fail value. If it does, return this instead in case some of
   // the registers are not available on the current system.
   if (reg->nub_info.size > 0) {
-std::basic_string zeros(reg->nub_info.size, '\0');
+std::vector zeros(reg->nub_info.size, '\0');
 append_hex_value(ostrm, zeros.data(), zeros.size(), false);
   }
 }
@@ -4219,7 +4219,7 @@
 ostrm << "";
   } else if (reg_entry->nub_info.reg == (uint32_t)-1) {
 if (reg_entry->nub_info.size > 0) {
-  std::basic_string zeros(reg_entry->nub_info.size, '\0');
+  std::vector zeros(reg_entry->nub_info.size, '\0');
   append_hex_value(ostrm, zeros.data(), zeros.size(), false);
 }
   } else {


Index: lldb/tools/debugserver/source/RNBRemote.cpp
===
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -2585,7 +2585,7 @@
   // fail value. If it does, return this instead in case some of
   // the registers are not available on the current system.
   if (reg->nub_info.size > 0) {
-std::basic_string zeros(reg->nub_info.size, '\0');
+std::vector zeros(reg->nub_info.size, '\0');
 append_hex_value(ostrm, zeros.data(), zeros.size(), false);
   }
 }
@@ -4219,7 +4219,7 @@
 ostrm << "";
   } else if (reg_entry->nub_info.reg == (uint32_t)-1) {
 if (reg_entry->nub_info.size > 0) {
-  std::basic_string zeros(reg_entry->nub_info.size, '\0');
+  std::vector zeros(reg_entry->nub_info.size, '\0');
   append_hex_value(ostrm, zeros.data(), zeros.size(), false);
 }
   } else {
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread Martin Storsjö via Phabricator via lldb-commits 
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158391/new/

https://reviews.llvm.org/D158391

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits 
DavidSpickett created this revision.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Which was done in https://reviews.llvm.org/D157058. This follows the fix
for lldb-server in https://reviews.llvm.org/D157589.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158391

Files:
  lldb/tools/debugserver/source/RNBRemote.cpp


Index: lldb/tools/debugserver/source/RNBRemote.cpp
===
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -2585,7 +2585,7 @@
   // fail value. If it does, return this instead in case some of
   // the registers are not available on the current system.
   if (reg->nub_info.size > 0) {
-std::basic_string zeros(reg->nub_info.size, '\0');
+std::vector zeros(reg->nub_info.size, '\0');
 append_hex_value(ostrm, zeros.data(), zeros.size(), false);
   }
 }
@@ -4219,7 +4219,7 @@
 ostrm << "";
   } else if (reg_entry->nub_info.reg == (uint32_t)-1) {
 if (reg_entry->nub_info.size > 0) {
-  std::basic_string zeros(reg_entry->nub_info.size, '\0');
+  std::vector zeros(reg_entry->nub_info.size, '\0');
   append_hex_value(ostrm, zeros.data(), zeros.size(), false);
 }
   } else {


Index: lldb/tools/debugserver/source/RNBRemote.cpp
===
--- lldb/tools/debugserver/source/RNBRemote.cpp
+++ lldb/tools/debugserver/source/RNBRemote.cpp
@@ -2585,7 +2585,7 @@
   // fail value. If it does, return this instead in case some of
   // the registers are not available on the current system.
   if (reg->nub_info.size > 0) {
-std::basic_string zeros(reg->nub_info.size, '\0');
+std::vector zeros(reg->nub_info.size, '\0');
 append_hex_value(ostrm, zeros.data(), zeros.size(), false);
   }
 }
@@ -4219,7 +4219,7 @@
 ostrm << "";
   } else if (reg_entry->nub_info.reg == (uint32_t)-1) {
 if (reg_entry->nub_info.size > 0) {
-  std::basic_string zeros(reg_entry->nub_info.size, '\0');
+  std::vector zeros(reg_entry->nub_info.size, '\0');
   append_hex_value(ostrm, zeros.data(), zeros.size(), false);
 }
   } else {
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits