Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems to be working after applying the fixes below. I was considering whether this shouldn't be moved to an even more platform-specific file (say `androidutil.py` or something), but I'll

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner added a comment. r259724 Repository: rL LLVM http://reviews.llvm.org/D16830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

This change broke Android testsuite run: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/5147 On Wed, Feb 3, 2016 at 11:20 AM, Zachary Turner via lldb-commits wrote: > zturner added a comment. > > In http://reviews.llvm.org/D16830#343232,

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

I ahad 3 CLs in progress locally and I guess I messed up a merge. There's supposed to be a subprocess.PIPE instead of just PIPE. I'll check in a fix shortly. On Wed, Feb 3, 2016 at 2:51 PM Siva Chandra wrote: > This change broke Android testsuite run: > >

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

tberghammer accepted this revision. tberghammer added a comment. Looks reasonable and I agree with Pavel in the idea of moving the android related utility functions into their own file for better separation Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:73-81

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

This revision was automatically updated to reflect the committed changes. Closed by commit rL259680: Move some android platform functions to lldbplatformutil. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D16830?vs=46721=46806#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner added a comment. In http://reviews.llvm.org/D16830#343232, @zturner wrote: > In http://reviews.llvm.org/D16830#342842, @tberghammer wrote: > > > Looks reasonable and I agree with Pavel in the idea of moving the android > > related utility functions into their own file for better

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner marked 2 inline comments as done. zturner added a comment. In http://reviews.llvm.org/D16830#342842, @tberghammer wrote: > Looks reasonable and I agree with Pavel in the idea of moving the android > related utility functions into their own file for better separation I thought about