sivachandra added a comment.
Thanks for the quick review.
I will put this in for now. Will revisit if a need for an elaborate solution
arises.
http://reviews.llvm.org/D18334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sivachandra updated this revision to Diff 51246.
sivachandra added a comment.
Explicitly set the alignment of the size field in the unpacked struct
to 8 bytes. This should take care of the case where in the host is i386
and the target is arm (for example).
http://reviews.llvm.org/D18334
Files:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. One other alternative is to get the type from the program if it
exists in the debug info and explore the struct using ValueObject. This would
get you out of the fixed
sivachandra added a comment.
This fixes an issue we are seeing with i386 JIT entry handling.
I have chosen a least disruptive change. However, since alignment is actually
determined by the ABI, one could add some API to the ABI interface to determine
the packing. However, it seemed like an
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added subscribers: lldb-commits, dsrbecky, tberghammer.
http://reviews.llvm.org/D18334
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Index:
