labath added a comment.
A random thought: will `getchar()` block the inferior on windows (because of
missing stdio forwarding, et al.). If it wont then this could be the cause of
the flakyness. If that's the case, then we can replace that call with something
that will surely halt progress,
labath added a comment.
In http://reviews.llvm.org/D18886#397843, @amccarth wrote:
> It's weird in that, if you run the test independently, it passes. But if you
> run it with the multiprocess test runner (ninja check-lldb), then it fails on
> this line:
>
> self.fail("Setting a breakpoint
amccarth added a comment.
It's weird in that, if you run the test independently, it passes. But if you
run it with the multiprocess test runner (ninja check-lldb), then it fails on
this line:
self.fail("Setting a breakpoint generated an unexpected event: %s" %
ovyalov added a comment.
In http://reviews.llvm.org/D18886#397637, @amccarth wrote:
> FYI: According to git bisect, this patch seems to have introduced a new test
> failure on Windows.
Thanks for the report - will fix today.
http://reviews.llvm.org/D18886
amccarth added a subscriber: amccarth.
amccarth added a comment.
FYI: According to git bisect, this patch seems to have introduced a new test
failure on Windows.
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL265843
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov added a comment.
In http://reviews.llvm.org/D18886#395216, @labath wrote:
> Does this fix an existing test or is a new issue? If it's new (it sounds like
> it is, as I don't see any test failures), could you also add a test for this.
> It shouldn't be too difficult to write one...
ovyalov updated this revision to Diff 53054.
ovyalov added a comment.
Added new TestBreakpointSetRestart test to cover the addressed issue.
http://reviews.llvm.org/D18886
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/Makefile
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received -
otherwise it leads to stopped inferior when setting breakpoint (when
m_interrupt_sent == true and signal is
10 matches
Mail list logo
