Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

Assert probably On Mon, Sep 5, 2016 at 4:04 AM Pavel Labath wrote: > labath added a subscriber: labath. > labath added a comment. > > > > > > Comment at: include/lldb/Host/FileSpec.h:712 > @@ +711,3 @@ > + PathSyntax syntax =

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

stigger added inline comments. Comment at: include/lldb/Host/FileSpec.h:712 @@ +711,3 @@ + PathSyntax syntax = ePathSyntaxHostNative, + llvm::Triple *triple = nullptr); + labath wrote: > I don't think the default-null parameter here is a

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

labath added a subscriber: labath. labath added a comment. Comment at: include/lldb/Host/FileSpec.h:712 @@ +711,3 @@ + PathSyntax syntax = ePathSyntaxHostNative, + llvm::Triple *triple = nullptr); + I don't think the default-null

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

For #2 you can use llvm::GetProcessTriple(), i will think about #1 when I have a chance to look at the code On Sat, Sep 3, 2016 at 2:38 PM Vyacheslav Karpukhin < vyaches...@karpukhin.com> wrote: > stigger added a comment. > > In https://reviews.llvm.org/D20041#533725, @zturner wrote: > > > How

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

stigger added a comment. In https://reviews.llvm.org/D20041#533725, @zturner wrote: > How difficult would be it be to eliminate the `PathSyntax` enumeration > entirely and update every user of `PathSyntax` to use a triple instead? I've attempted to do it and hit two issues which I'm not sure

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

zturner added a subscriber: zturner. zturner added a comment. I like the approach taken here in general. One thing that I wonder about, if we have the Triple, why do we even need the PathSyntax at all? In light of the fact that not all Posix filesystems are case sensitive, this calls into

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

stigger added a comment. Ping. https://reviews.llvm.org/D20041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

stigger added a comment. These are valid points, but they apply to Linux and Windows as well: nothing prevents you from mounting a case-insensitive FS on Linux or a case-sensitive network share on Windows. However, in most cases the file system is going to be case-sensitive on Linux and

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. I don't know if this is a safe change. Mac OS X filesystems like HFS Plus may be case-insensitive (but case preserving) or they may be case sensitive. Network filesystems mounted on a Mac may be case sensitive.

[Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

stigger created this revision. stigger added a reviewer: zturner. stigger added a subscriber: lldb-commits. - File path comparisons should be case-insensitive on OS X - Fixed TestBreakpointCaseSensitivity http://reviews.llvm.org/D20041 Files: include/lldb/Host/FileSpec.h