ovyalov closed this revision.
ovyalov added a comment.
Submitted as r270590
http://reviews.llvm.org/D20548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437567, @labath wrote:
> According to
> https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255=-2147217396,
> characters with codes 1..31 (basically `< ' '`), are illegal as well. We
> might as well
clayborg added a comment.
At some point we should probably make a host layer call like:
const char *const char *Host::GetIllegalFilenameCharacters();" so that each
host can determine the correct thing for the current host. Then FileSpec can be
updated to use this function handle this with a
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
According to
https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255=-2147217396,
characters with codes 1..31 (basically `< ' '`), are illegal as well. We
ovyalov updated this revision to Diff 58180.
ovyalov added a comment.
Added asterisk symbol
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
---
ovyalov created this revision.
ovyalov added reviewers: labath, clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
ModuleCache hostname may contain symbols that are not allowed in filenames -
for example, in Android device_id is used as a
